Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed state of Agreement + Motions Finalization addition #3023

Open
arrenv opened this issue Aug 28, 2024 · 1 comment · May be fixed by #3332
Open

Completed state of Agreement + Motions Finalization addition #3023

arrenv opened this issue Aug 28, 2024 · 1 comment · May be fixed by #3332
Assignees
Labels
bug Something isn't working Pagepro Issues handled by the Pagepro team

Comments

@arrenv
Copy link
Member

arrenv commented Aug 28, 2024

Teamwork task: Completed state of Agreement missing staking overview + Motions Finalization addition

Description

  • Agreement card should show the staking overview for the user.
  • We would like to update the top description to be more accurate in each case.
  • We would like to update the title to instead just be "Overview".
  • We would like to add a Completed row with the date the motion was finalized.
  • We would like to rename the labels of the fields.

Figma link: Complete action card

Showing user who did not stake or vote (outcome passed)

image

Showing user who did stake and vote (outcome passed)

image

Showing user who did not stake but did vote (outcome failed)

image

Actual behaviour

  • There is no stakes overview showing in the completed state after returning stakes if the agreement passes. It seems to work fine when failing.
  • The description is incorrect in the finalized state.

image

@arrenv arrenv added the bug Something isn't working label Aug 28, 2024
@rdig rdig added the label Sep 10, 2024
@arrenv arrenv added Pagepro Issues handled by the Pagepro team and removed labels Oct 4, 2024
@adam-strzelec adam-strzelec removed the Pagepro Issues handled by the Pagepro team label Oct 14, 2024
@adam-strzelec
Copy link
Contributor

adam-strzelec commented Oct 14, 2024

getColonyAction query returns the flag isFinalized equals false inside motionData after finalize action

@arrenv arrenv added the Pagepro Issues handled by the Pagepro team label Oct 14, 2024
@arrenv arrenv changed the title Completed state of Agreement missing staking overview + Motions Finalization addition Completed state of Agreement + Motions Finalization addition Oct 14, 2024
@adam-strzelec adam-strzelec linked a pull request Oct 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Pagepro Issues handled by the Pagepro team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants