Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proxy colonies M3] feat: implement versioning for all PayoutClaimed related logic #4230

Open
4 tasks
bassgeta opened this issue Feb 3, 2025 · 0 comments
Open
4 tasks
Assignees
Labels
enhancement New feature or request

Comments

@bassgeta
Copy link
Contributor

bassgeta commented Feb 3, 2025

Specification

Story

As a user using an older version of the colony, I can still use expenditures and simple payments.

Description

Since a new chainId argument was added to the PayoutClaimed event, now when it's claimed (either via the payment builder or the OneTxPayment extension), we need to make sure old colony versions will keep working.
To keep it simple until we start tackling expenditures down the line, we should do the following changes:

Sagas:

  • The simple payment sagas shouldn't pass the chainId to the contracts if the version doesn't support it
  • leave expenditure sagas intact for now, since the old methods still exist, but are deprecated

Block ingestor:

List of impacted files:
Image

Implementation

This issue is complete when...

  • Claiming an expenditure still works as intended on old colony versions
  • Claiming an expenditure works as intended on new colony versions
  • Simple payments work on old colony versions
  • Simple payments work on new colony versions
@bassgeta bassgeta added the enhancement New feature or request label Feb 3, 2025
@mmioana mmioana self-assigned this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants