feat: disable custom transactions for colony version less then 17 and show an error #4262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmioana
previously approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Really nice work on this @Nortsova 🙌
After changing the minimum version to 18, the banner is shown and the form is disabled
Screen.Recording.2025-02-10.at.10.00.31.mov
After reverting the change, the form is re-enabled and the banner is no longer shown
Nice work! ✨
mmioana
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For any colony version older than v17, the following error callout should show when "Custom transaction" action is selected:
"Custom transactions requires Colony Network version 17 or higher."
It should also include a link to the Upgrade colony action with the link text "Upgrade colony".
Testing
Step 1. Open
src/components/v5/common/ActionSidebar/partials/hooks.tsand update line 116 to 18 version.Step 2. Open "Custom transactions"
Step 3. Verify that form is disabled and you can see an error
Step 4. Verify that 'Upgrade colony' button redirect to 'Upgrade colony' action
Step 5. Open
src/components/v5/common/ActionSidebar/partials/hooks.tsand update line 116 to 17 version.Step 6. Verify that the form is enabled again
Resolves #4261