Fix panic caused by despawning entity with ColliderOf
#677
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #676.
#671 changed the
ColliderParent
component to aColliderOf
relationship. Because Bevy does not normally allow relationships to point to their own entities, this required a partial manual implementation of theRelationship
trait. However, I left the defaulton_replace
implementation, which (as it turns out) panics if the target entity does not exist, which is possible when despawning an entity and the relationship points to itself.Solution
Manually implement
on_replace
in a non-panicking way. Also replace some panicking uses ofremove
withtry_remove
.Ideally this would be fixed by Bevy allowing self-relationships though.