Merge remote-tracking branch 'origin/main' into mobile

Author: Lily

.github/ISSUE_TEMPLATE/bugs.yml

@@ -13,15 +13,13 @@ body:
     id: terminal
     attributes:
       label: "Command Prompt/Terminal/Crash logs (if existing)"
-      render: bash
     validations:
       required: false
 
   - type: textarea
     id: reproduce
     attributes:
       label: "Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible."
-      render: bash
     validations:
       required: false
 

README.md

@@ -10,24 +10,23 @@ THIS NOT THE JS ENGINE BASE REPO. THIS BRANCH MADE BY [mcagabe19](https://github
 </h1>
 
 <h3 align="center">
-  <b>JS Engine is a heavily modified Psych Engine fork Jordan made, with lower-end PCs and more customization in mind while also aiming to be a replacement for OS "Engine".</b>
+  <b>JS Engine is a heavily modified Psych Engine fork, with lower-end PCs and more customization in mind.</b>
 </h3>
 
 README.md revamped by [Nael2xd](https://youtube.com/@nael2xd?si=axwJrY_8jdlXUwSm)
 
-If you're looking for the Desktop version, [go here!](https://github.com/JordanSantiagoYT/FNF-JS-Engine)
+_If you're looking for the deskto version, [go here!](https://github.com/JordanSantiagoYT/FNF-JS-Engine)_
 
 ## Welcome
 
-Hello and welcome to JS Engine Mobile's github repo, where you can download the port and play spammy charts or have fun with the engine.
+Welcome to JS Engine's github repo, where you can download the engine and make spammy charts or have fun with the engine.
 
 This contains lots and lots of customizable and features built in to JS Engine, if you wanna see most of them listed, you can see it below this text
 
 # Features/Performances in JS ENGINE
 
-This fork of this engine has tons of features and performances, most will be listed but some of them won't because there's a lot of it.
+**This fork has tons of features and performances features, most will be listed:
 
-The features/performances included are:
 - No BotPlay lag!
 - Faster Song Loading!
 - Loading songs longer than 20 minutes!
@@ -42,8 +41,6 @@ There is like lots and lots of stuff Jordan have missed, but at least you would
 
 # Screenshots
 
-Here are some screenshots of what the engine looks like. 
-
 ![Screenshot 2024-07-07 14-00-00](https://github.com/JordanSantiagoYT/FNF-JS-Engine/assets/108278470/d4e89995-fa14-40bf-a5d6-d1647548fd93)
 
 ![Screenshot 2024-07-07 14-01-15](https://github.com/JordanSantiagoYT/FNF-JS-Engine/assets/108278470/b6d7d5ef-196d-4c39-9055-97815d63cdf0)

docs/TemplateScript.lua

@@ -1,38 +1,38 @@
 -- Lua stuff
 
 function onCreate()
-	-- triggered when the lua file is started, some variables weren't created yet
+	-- When the lua file is started/created, some variables weren't created yet
 end
 
 function onCreatePost()
-	-- end of "create"
+	-- End of "create", all variables have already been loaded, recommended.
 end
 
 function onDestroy()
-	-- triggered when the lua file is ended (Song fade out finished)
+	-- When the lua file is ended (Song fade out finished)
 end
 
 
 -- Gameplay/Song interactions
 function onBeatHit()
-	-- triggered 4 times per section
+	-- Triggered 4 times per section
 end
 
 function onStepHit()
-	-- triggered 16 times per section
+	-- Triggered 16 times per section
 end
 
 function onUpdate(elapsed)
-	-- start of "update", some variables weren't updated yet
+	-- Start of "update", some variables weren't updated yet
 end
 
 function onUpdatePost(elapsed)
-	-- end of "update"
+	-- End of "update"
 end
 
 function onStartCountdown()
-	-- countdown started, duh
-	-- return Function_Stop if you want to stop the countdown from happening (Can be used to trigger dialogues and stuff! You can trigger the countdown with startCountdown())
+	-- Countdown started, duh
+	-- Return Function_Stop if you want to stop the countdown from happening (Can be used to trigger dialogues and stuff! You can trigger the countdown with startCountdown())
 	return Function_Continue;
 end
 
@@ -49,7 +49,7 @@ function onSongStart()
 end
 
 function onEndSong()
-	-- song ended/starting transition (Will be delayed if you're unlocking an achievement)
+	-- Song ended/starting transition (Will be delayed if you're unlocking an achievement)
 	-- return Function_Stop to stop the song from ending for playing a cutscene or something.
 	return Function_Continue;
 end
@@ -80,11 +80,11 @@ end
 
 -- Dialogue (When a dialogue is finished, it calls startCountdown again)
 function onNextDialogue(line)
-	-- triggered when the next dialogue line starts, dialogue line starts with 1
+	-- Triggered when the next dialogue line starts, dialogue line starts with 1
 end
 
 function onSkipDialogue(line)
-	-- triggered when you press Enter and skip a dialogue line that was still being typed, dialogue line starts with 1
+	-- Triggered when you press Enter and skip a dialogue line that was still being typed, dialogue line starts with 1
 end
 
 

source/PauseSubState.hx

@@ -407,7 +407,7 @@ class PauseSubState extends MusicBeatSubstate
 
 	override function destroy()
 	{
-		pauseMusic.destroy();
+		if (pauseMusic != null) pauseMusic.destroy();
 		if (PlayState != null) MusicBeatState.windowNameSuffix = " - " + PlayState.SONG.song + " " + (PlayState.isStoryMode ? "(Story Mode)" : "(Freeplay)");
 
 		super.destroy();