why doesn't this code work

[nate902011]

Describe your problem here.

im trying to make compatibility with the old judgeCountStrings.txt system and it doesn't work
here's the relevant code:

local function setupJudgeStrings(rType)
	--To add more quotes for your specific rating type, add a comma at the end of the last one, and add another field for your custom rating type. (Be sure to use your list.txt name!)
	local presets = {
   		["Default"] = {"Perfects","Sicks","Goods","Bads","Shits","Misses"},
   		["Doki Doki+"] = {"Very Dokis","Dokis","Goods","OKs","Nos","Misses"},
   		["FIRE IN THE HOLE"] = {"Easys","Normals","Hards","Harders","Insanes","Extreme Demon Fails"},
   		["NMCW"] = {"Amazings","Wows","Nices","Bruhs","Bee-womps","Misses"},
   		["TGT V4"] = {"Killers","Awesomes","Cools","Gays","Retardeds","Fails"},
   		["VS Impostor"] = {"Perfects","Sussys","Sus'","Sads","Asses","Misses"},
   		["Yeahs"] = {"Super Yeahs","Yeahs","Okays","Thin Ices","Nos","Super Nos"}
   	}
    local normalRating = 'ratings/'.. stringTrim(string.gsub(string.lower(getPropertyFromClass('ClientPrefs', 'ratingType')), ' ', '-')) ..'/' --pneumonoultramicroscopicsilicovolcanoconiosis

    local thetxtfile = 'images/'.. normalRating ..'judgeCountStrings.txt'
    if checkFileExists(thetxtfile) then
        judgeTxt = getTextFromFile(thetxtfile)
        for line in string.gmatch(judgeTxt, "([^\n]+)") do
            table.insert(compatibility, line)
        end
    end
    return presets[rType] or compatibility or presets["Default"]
end

function stringTrim(str)
    return string.gsub(str, "^%s*(.-)%s*$", "%1")
end

the normalRating part works (despite looking horrible), the getTextFromFile part finally worked this time (i checked), its the turning the string into the table part that fails to do anything and idk how to fix it. (yes, judgeCountStrings.txt is in the right location and works in 1.48.1)
heres the luaDebugMode lua trace:

What version did the bug occur?

a few commits after v1.49.0 prerelease

Did you check if the problem occurs in the latest build?

None

Commit build or Release build?

Commit Build of latest version.

Did you check if there's a problem that you are trying to figure out on the issue linked below?

Yes

Did you check if there's any similar issues?

No

Are you modding a build from source or with Lua?

Lua

Command Prompt/Terminal logs/Crash logs (if existing)

No response

What is your build target?

Windows x64

Did you edit anything in this build? If so, mention or summarize your changes.

no

[JordanSantiagoYT]

share the full script

[nate902011]

share the full script

--recreated by nate902011, aka Just Another Random on yt
--code cleanups suggested by NAEL2XD, now the code is more readable
--Further code cleanups by Jordan Santiago.

    oppJudgement = true --for those who want it ig; basically the opponents hits and nps (if you have that option enabled)
    judgeBasedOnRatingType = true --whether or not you want the judgeCountStrings to be based on you rating type setting in ui
    judgeCountStrings = {}

local function setupJudgeStrings(rType)
	--To add more quotes for your specific rating type, add a comma at the end of the last one, and add another field for your custom rating type. (Be sure to use your list.txt name!)
	local presets = {
   		["Default"] = {"Perfects","Sicks","Goods","Bads","Shits","Misses"},
   		["Doki Doki+"] = {"Very Dokis","Dokis","Goods","OKs","Nos","Misses"},
   		["FIRE IN THE HOLE"] = {"Easys","Normals","Hards","Harders","Insanes","Extreme Demon Fails"},
   		["NMCW"] = {"Amazings","Wows","Nices","Bruhs","Bee-womps","Misses"},
   		["TGT V4"] = {"Killers","Awesomes","Cools","Gays","Retardeds","Fails"},
   		["VS Impostor"] = {"Perfects","Sussys","Sus'","Sads","Asses","Misses"},
   		["Yeahs"] = {"Super Yeahs","Yeahs","Okays","Thin Ices","Nos","Super Nos"},
   		["JAREM"] = {"Haxxers","Pretty Goods","OKs","Awfuls","You Sucks","Misses"}
   	}
    local normalRating = 'ratings/'.. stringTrim(string.gsub(string.lower(getPropertyFromClass('ClientPrefs', 'ratingType')), ' ', '-')) ..'/' --pneumonoultramicroscopicsilicovolcanoconiosis

    local thetxtfile = 'images/'.. normalRating ..'judgeCountStrings.txt'
    if checkFileExists(thetxtfile) then
        judgeTxt = getTextFromFile(thetxtfile)
        for line in string.gmatch(judgeTxt, "([^\n]+)") do
            table.insert(compatibility, line)
        end
    end
    return presets[rType] or compatibility or presets["Default"]
end

function onCreatePost()
    luaDebugMode = true
    makeLuaText('judgementCounter', '', screenWidth, 0, screenHeight / 2 - 80)
    addLuaText('judgementCounter')
    setTextAlignment('judgementCounter', 'left')
    setTextBorder('judgementCounter', 2, '000000')
    setTextSize('judgementCounter', 20)
    ratingType = getPropertyFromClass('ClientPrefs', 'ratingType')

	if judgeBasedOnRatingType then
		judgeCountStrings = setupJudgeStrings(ratingType)
	else --if you want to customize this field ONLY, change the fields here. first one is Perfects, second is Sicks etc.
		judgeCountStrings = {"Perfects","Sicks","Goods","Bads","Shits","Misses"}
	end
    
    da_rating = setupJudgeStrings()
end

function onUpdatePost()
    if getPropertyFromClass('ClientPrefs', 'showcaseMode') then
    	return Function_Stop;
    end

    --first chunk of info
    hitStr = 'Hits: '.. numberShit(getProperty('totalNotesPlayed')) ..' / '.. numberShit(getProperty('totalNotes')) ..' ('.. roundPc((getProperty('totalNotesPlayed')/getProperty('totalNotes'))*100, 2) ..'%)'

    --the second chunk
    -- ratingStr = '' --this has to be here or var ratingStr will be nil and the script will break
    -- for i = 2, 5 do
    --     ratingStr = ratingStr .. '\n'.. judgeCountStrings[i] ..': '.. numberShit(getProperty(string.lower(da_rating[i])))
    -- end
    -- ratingStr = ratingStr ..'\n'.. judgeCountStrings[6] ..': '.. numberShit(misses)
    ratingStr = '\n'.. judgeCountStrings[2] ..': '.. numberShit(getProperty('sicks')) ..'\n'.. judgeCountStrings[3] ..': '.. numberShit(getProperty('goods')) ..'\n'.. judgeCountStrings[4] ..': '.. numberShit(getProperty('bads')) ..'\n'.. judgeCountStrings[5] ..': '.. numberShit(getProperty('shits')) ..'\n'.. judgeCountStrings[6] ..': '.. numberShit(misses)

    --the marvelous or perfect or whatever
    if not getPropertyFromClass('ClientPrefs', 'noMarvJudge') then
        ratingStr = '\n'.. judgeCountStrings[1] ..': '.. numberShit(getProperty('perfects')).. ratingStr
    end

    --combo info bc adhd
    if getPropertyFromClass('ClientPrefs', 'showComboInfo') then
        comboStr = 'Combo: '.. numberShit(getProperty('combo')) ..'/'.. numberShit(getProperty('maxCombo')) ..'\n'
    end

    --nps bc adhd and big number go high
    if getPropertyFromClass('ClientPrefs', 'showNPS') then
        npsCnt = '\nNPS: '.. numberShit(getProperty('nps')) ..'/'.. numberShit(getProperty('maxNPS'))
    end

    --opponent info bc i wanted to add it
    if oppJudgement and getProperty('opponentNoteTotal') ~= 0 then
        oppJudgeStr = '\n\nOpponent Hits: '.. numberShit(getProperty('enemyHits')) ..' / '.. numberShit(getProperty('opponentNoteTotal')) ..' ('.. roundPc((getProperty('enemyHits')/getProperty('opponentNoteTotal'))*100, 2) ..'%)'
        if getPropertyFromClass('ClientPrefs', 'showNPS') then
            oppJudgeStr = oppJudgeStr .. '\nOpponent NPS: '.. numberShit(getProperty('oppNPS')) ..'/'.. numberShit(getProperty('maxOppNPS'))
        end
	else oppJudgeStr = ''
	end

    --botplay stuff
    if botPlay then
        comboStr = ''
        ratingStr = ''
    end

    -- the if down below is an attempt to reduce lag (prob not by much) by not updating the counter every frame
    if getTextString('judgementCounter') ~= comboStr .. hitStr .. ratingStr .. npsCnt .. oppJudgeStr then
        setTextString('judgementCounter', comboStr .. hitStr .. ratingStr .. npsCnt .. oppJudgeStr)
    end
end

function roundPc(numb, dcpl)
    local multi = 10^(dcpl or 0)
    return math.floor(numb * multi + 0.5) / multi
end

number = 0
function numberShit(num)
	if nil ~= num ~= number then
		number = tonumber(num)
		return runHaxeCode('PlayState.formatNumber('..math.floor(number + 0.5)..')')
	end
end

function stringTrim(str)
    return string.gsub(str, "^%s*(.-)%s*$", "%1")
end

[nate902011]

basically the same ratings counter script but with

    local normalRating = 'ratings/'.. stringTrim(string.gsub(string.lower(getPropertyFromClass('ClientPrefs', 'ratingType')), ' ', '-')) ..'/' --pneumonoultramicroscopicsilicovolcanoconiosis

    local thetxtfile = 'images/'.. normalRating ..'judgeCountStrings.txt'
    if checkFileExists(thetxtfile) then
        judgeTxt = getTextFromFile(thetxtfile)
        for line in string.gmatch(judgeTxt, "([^\n]+)") do
            table.insert(compatibility, line)
        end
    end
    return presets[rType] or compatibility or presets["Default"]
end

added to setupJudgeStrings and an extra function:

function stringTrim(str)
    return string.gsub(str, "^%s*(.-)%s*$", "%1")
end

[JordanSantiagoYT]

you commented out this line of code

[nate902011]

that was for the optimization i suggested but it called setupJudgeStrings every frame so i used the original line instead

[JordanSantiagoYT]

you could put ratingStr = '' at the top of the script

[nate902011]

you could put ratingStr = '' at the top of the script

(i commented out the table part to prove this wouldn't work, if anything doing it wound make a lag tester)

[nate902011]

what im saying for the question is that the script says the table part

    if checkFileExists(thetxtfile) then
        judgeTxt = getTextFromFile(thetxtfile)
        for line in string.gmatch(judgeTxt, "([^\n]+)") do
            table.insert(compatibility, line)
        end
    end

is nil, ratingStr has nothing to do with it. in fact, the script works just fine without the table part and the or compatibility in the return statement.

[JordanSantiagoYT]

ah, i see what happened now

you see, you're telling the game to insert values to a variable that's never initialized. because of that, compatibility is nil, and the game returns an error when trying to do stuff with it

[nate902011]

ah, i see what happened now

you see, you're telling the game to insert values to a variable that's never initialized. because of that, compatibility is nil, and the game returns an error when trying to do stuff with it

i fixed that and now it's giving this error for the numberShit function (i didn't even touch it!):

[nate902011]

i also fixed the call setupJudgeStrings every frame issue by putting da_rating = setupJudgeStrings() in onCreatePost instead of onUpdatePost

[nate902011]

fixed by inserting it as its rating type into presets. here's an updated version of the ratings counter:

--recreated by nate902011, aka Just Another Random on yt
--code cleanups suggested by NAEL2XD, now the code is more readable
--Further code cleanups by Jordan Santiago.
    oppJudgement = false --for those who want it ig; basically the opponents hits and nps (if you have that option enabled)
    judgeBasedOnRatingType = true --whether or not you want the judgeCountStrings to be based on you rating type setting in ui
    judgeCountStrings = {}

local function setupJudgeStrings(rType)
	--To add more quotes for your specific rating type, add a comma at the end of the last one, and add another field for your custom rating type. (Be sure to use your list.txt name!)
	local presets = {
   		["Default"] = {"Perfects","Sicks","Goods","Bads","Shits","Misses"},
   		["Doki Doki+"] = {"Very Dokis","Dokis","Goods","OKs","Nos","Misses"},
   		["FIRE IN THE HOLE"] = {"Easys","Normals","Hards","Harders","Insanes","Extreme Demon Fails"},
   		["NMCW"] = {"Amazings","Wows","Nices","Bruhs","Bee-womps","Misses"},
   		["TGT V4"] = {"Killers","Awesomes","Cools","Gays","Retardeds","Fails"},
   		["VS Impostor"] = {"Perfects","Sussys","Sus'","Sads","Asses","Misses"},
   		["Yeahs"] = {"Super Yeahs","Yeahs","Okays","Thin Ices","Nos","Super Nos"}
   	}

    --for compatibility with the old judgeCountStrings.txt system
    local normalRating = 'ratings/'.. stringTrim(string.gsub(string.lower(getPropertyFromClass('ClientPrefs', 'ratingType')), ' ', '-')) ..'/' --pneumonoultramicroscopicsilicovolcanoconiosis

    local thetxtfile = 'images/'.. normalRating ..'judgeCountStrings.txt'
    if checkFileExists(thetxtfile) then
        presets[getPropertyFromClass('ClientPrefs', 'ratingType')] = {}
        judgeTxt = getTextFromFile(thetxtfile)
        for line in string.gmatch(judgeTxt, "([^\n]+)") do
            table.insert(presets[getPropertyFromClass('ClientPrefs', 'ratingType')], stringTrim(line)) --stringtrim there to prevent another newline past the line string
        end
    end
    return presets[rType] or presets["Default"]
end

function onCreatePost()
    luaDebugMode = true
    makeLuaText('judgementCounter', '', screenWidth, 0, screenHeight / 2 - 80)
    addLuaText('judgementCounter')
    setTextAlignment('judgementCounter', 'left')
    setTextBorder('judgementCounter', 2, '000000')
    setTextSize('judgementCounter', 20)
    ratingType = getPropertyFromClass('ClientPrefs', 'ratingType')

	if judgeBasedOnRatingType then
		judgeCountStrings = setupJudgeStrings(ratingType)
	else --if you want to customize this field ONLY, change the fields here. first one is Perfects, second is Sicks etc.
		judgeCountStrings = {"Perfects","Sicks","Goods","Bads","Shits","Misses"}
	end
    
    da_rating = setupJudgeStrings()
end

function onUpdatePost()
    if getPropertyFromClass('ClientPrefs', 'showcaseMode') then
    	return Function_Stop;
    end

    --first chunk of info
    hitStr = 'Hits: '.. numberShit(getProperty('totalNotesPlayed')) ..' / '.. numberShit(getProperty('totalNotes')) ..' ('.. roundPc((getProperty('totalNotesPlayed')/getProperty('totalNotes'))*100, 2) ..'%)'

    --the second chunk
    ratingStr = '' --this has to be here or var ratingStr will be nil and the script will break
    for i = 2, 5 do
        ratingStr = ratingStr .. '\n'.. judgeCountStrings[i] ..': '.. numberShit(getProperty(string.lower(da_rating[i])))
    end
    ratingStr = ratingStr ..'\n'.. judgeCountStrings[6] ..': '.. numberShit(misses)

    --the marvelous or perfect or whatever
    if not getPropertyFromClass('ClientPrefs', 'noMarvJudge') then
        ratingStr = '\n'.. judgeCountStrings[1] ..': '.. numberShit(getProperty('perfects')).. ratingStr
    end

    --combo info bc adhd
    if getPropertyFromClass('ClientPrefs', 'showComboInfo') then
        comboStr = 'Combo: '.. numberShit(getProperty('combo')) ..'/'.. numberShit(getProperty('maxCombo')) ..'\n'
    end

    --nps bc adhd and big number go high
    if getPropertyFromClass('ClientPrefs', 'showNPS') then
        npsCnt = '\nNPS: '.. numberShit(getProperty('nps')) ..'/'.. numberShit(getProperty('maxNPS'))
    end

    --opponent info bc i wanted to add it
    if oppJudgement and getProperty('opponentNoteTotal') ~= 0 then
        oppJudgeStr = '\n\nOpponent Hits: '.. numberShit(getProperty('enemyHits')) ..' / '.. numberShit(getProperty('opponentNoteTotal')) ..' ('.. roundPc((getProperty('enemyHits')/getProperty('opponentNoteTotal'))*100, 2) ..'%)'
        if getPropertyFromClass('ClientPrefs', 'showNPS') then
            oppJudgeStr = oppJudgeStr .. '\nOpponent NPS: '.. numberShit(getProperty('oppNPS')) ..'/'.. numberShit(getProperty('maxOppNPS'))
        end
	else oppJudgeStr = ''
	end

    --botplay stuff
    if botPlay then
        comboStr = ''
        ratingStr = ''
    end

    -- the if down below is an attempt to reduce lag (prob not by much) by not updating the counter every frame
    if getTextString('judgementCounter') ~= comboStr .. hitStr .. ratingStr .. npsCnt .. oppJudgeStr then
        setTextString('judgementCounter', comboStr .. hitStr .. ratingStr .. npsCnt .. oppJudgeStr)
    end
end

function roundPc(numb, dcpl)
    local multi = 10^(dcpl or 0)
    return math.floor(numb * multi + 0.5) / multi
end


number = 0
function numberShit(num)
	if nil ~= num ~= number then
		number = tonumber(num)
		return runHaxeCode('PlayState.formatNumber('..math.floor(number + 0.5)..')')
	end
end

function stringTrim(str)
    return string.gsub(str, "^%s*(.-)%s*$", "%1")
end