You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This seems to use the ConfigurationFunctions.ShouldQuote instead of my delegate, I believe because it gets copied here locally on construction of CsvWriter:
I'm updating from v15 to v30, so I'm still trying to figure out all the changes. Is the Context.Configuration meant to expose mutable fields on the writer's configuration? If so, should the WriteField method use configuration.ShouldQuote instead of storing a local copy on construction?
I understand I can set the configuration and pass it to CsvWriter, but seems like Context.Configuration.ShouldQuote should not be settable if its not intended to take effect.
The text was updated successfully, but these errors were encountered:
gmkado
changed the title
CsvContext.ConfigurationShouldQuote is not usedCsvContext.Configuration.ShouldQuote is not used
Oct 4, 2024
Changed CsvConfiguration to a read only record to eliminate threading issues.
It looks like copying the config values to a local private copy after passing CsvConfiguration to the constructor was also done because of threading issues. #1623 (comment)
I'm using v30.0.1 but I believe this is true for the latest.
This seems to use the
ConfigurationFunctions.ShouldQuote
instead of my delegate, I believe because it gets copied here locally on construction of CsvWriter:CsvHelper/src/CsvHelper/CsvWriter.cs
Line 121 in 852bd46
I'm updating from v15 to v30, so I'm still trying to figure out all the changes. Is the
Context.Configuration
meant to expose mutable fields on the writer's configuration? If so, should theWriteField
method useconfiguration.ShouldQuote
instead of storing a local copy on construction?I understand I can set the configuration and pass it to CsvWriter, but seems like
Context.Configuration.ShouldQuote
should not be settable if its not intended to take effect.The text was updated successfully, but these errors were encountered: