Skip to content

Auth using environment variables #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 12, 2025
Merged

Auth using environment variables #56

merged 5 commits into from
Feb 12, 2025

Conversation

characat0
Copy link
Contributor

This PR modifies the default constructor to read environment variables MLFLOW_TRACKING_USERNAME and MLFLOW_TRACKING_PASSWORD for credentials and creates the Authorization header using basic auth.

@pebeto pebeto self-requested a review October 23, 2024 18:59
@pebeto pebeto added the enhancement New feature or request label Oct 23, 2024
Copy link
Member

@pebeto pebeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but tests are required for almost every PR. Don't forget to add the new env variables here.

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.39%. Comparing base (7067af0) to head (0a92b04).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   89.18%   90.39%   +1.20%     
==========================================
  Files          19       21       +2     
  Lines         333      406      +73     
==========================================
+ Hits          297      367      +70     
- Misses         36       39       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pebeto pebeto merged commit 11ab5d5 into JuliaAI:main Feb 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants