Fix sizehint for VectorOfArrays(#35)

JuliaArrays · Nov 3, 2023 · 3212544 · 3212544
1 parent 3a6f5ba
commit 3212544
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/vector_of_arrays.jl b/src/vector_of_arrays.jl
@@ -363,7 +363,7 @@ end
 
 
 function Base.sizehint!(A::VectorOfArrays{T,N}, n, s::Dims{N}) where {T,N}
-    sizehint!(A.data, n * mul(s))
+    sizehint!(A.data, n * prod(s))
     sizehint!(A.elem_ptr, n + 1)
     sizehint!(A.kernel_size, n)
     A

diff --git a/test/vector_of_arrays.jl b/test/vector_of_arrays.jl
@@ -324,4 +324,10 @@ using ArraysOfArrays: full_consistency_checks, append_elemptr!, element_ptr
             @test @inferred(do_map(identity, A)) === A
         end
     end
+
+    @testset "resize" begin
+        A1 = VectorOfArrays{Float64, 1}(ref_AoA1(Float64, 3))
+        sizehint!(A1, 5, (10000,))
+        @test ccall(:jl_array_size, Int, (Any, UInt), A1.data, 1) == 5*10000
+    end
 end