Skip to content

Commit abea9fa

Browse files
authored
Revert "Define dataids for PseudoBlockArrays" (#370)
* Revert "Define dataids for PseudoBlockArrays (#364)" This reverts commit d4939b3. * Test against LazyBandedMatrices
1 parent 8b0c8e4 commit abea9fa

File tree

3 files changed

+1
-5
lines changed

3 files changed

+1
-5
lines changed

.github/workflows/downstream.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ jobs:
3232
package:
3333
- {repo: BlockBandedMatrices.jl, group: JuliaLinearAlgebra}
3434
- {repo: ApproxFunBase.jl, group: JuliaApproximation}
35+
- {repo: LazyBandedMatrices.jl, group: JuliaLinearAlgebra}
3536
# - {repo: InfiniteLinearAlgebra.jl, group: JuliaLinearAlgebra}
3637

3738
steps:

src/pseudo_blockarray.jl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,8 +192,6 @@ AbstractArray{T,N}(A::PseudoBlockArray) where {T,N} = PseudoBlockArray(AbstractA
192192

193193
copy(A::PseudoBlockArray) = PseudoBlockArray(copy(A.blocks), A.axes)
194194

195-
Base.dataids(A::PseudoBlockArray) = (Base.dataids(A.blocks)..., mapreduce(Base.dataids, (x,y) -> (x..., y...), A.axes)...)
196-
197195
###########################
198196
# AbstractArray Interface #
199197
###########################

test/test_blockarrays.jl

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -379,9 +379,6 @@ end
379379
fill!(q2, 0)
380380
copyto!(q2, view(BA_1, Block(1)))
381381
@test q2 == q
382-
383-
@test Base.mightalias(BA_1, view(BA_1, Block(1,1)))
384-
@test Base.mightalias(BA_1, axes(BA_1, 1))
385382
end
386383
fill!(BA_1, 1.0)
387384
@test BA_1 == ones(size(BA_1))

0 commit comments

Comments
 (0)