Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specialize unchecked_oneto #160

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Mar 12, 2024

On upcoming julia versions, Base occasionally uses unchecked_oneto where it used to previously use oneto. This requires us to specialize unchecked_oneto as well to get tests to pass.

See JuliaLang/julia#52481

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.00%. Comparing base (377308c) to head (cadca2a).
Report is 2 commits behind head on master.

Files Patch % Lines
src/infrange.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
- Coverage   86.04%   86.00%   -0.05%     
==========================================
  Files           6        6              
  Lines         738      743       +5     
==========================================
+ Hits          635      639       +4     
- Misses        103      104       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub
Copy link
Member Author

jishnub commented Mar 12, 2024

This method can't be tested on current versions, as it is only added for an upcoming version. It should be tested already on the upcoming versions, as the tests on nightly fail without this.

@dlfivefifty dlfivefifty merged commit 2a1dabc into JuliaArrays:master Mar 12, 2024
7 of 9 checks passed
@jishnub jishnub deleted the uncheckedoneto branch March 12, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants