Trying to allow Int8 as indices
#371
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #371 +/- ##
==========================================
- Coverage 96.57% 95.58% -0.99%
==========================================
Files 6 6
Lines 467 476 +9
==========================================
+ Hits 451 455 +4
- Misses 16 21 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
giordano
reviewed
Jan 30, 2026
giordano
left a comment
giordano
left a comment
There was a problem hiding this comment.
I'll defer the decision about adding a new type parameter to the maintainers of the package
| @static if isdefined(Adapt, :parent_type) | ||
| # To support Adapt 3.0 which doesn't have parent_type defined | ||
| Adapt.parent_type(::Type{OffsetArray{T,N,AA,I}}) where {T,N,AA,I} = AA | ||
| Adapt.parent_type(::Type{OffsetArray{T,N,AA}}) where {T,N,AA} = AA |
There was a problem hiding this comment.
This method is probably redundant at this point
Suggested change
| Adapt.parent_type(::Type{OffsetArray{T,N,AA}}) where {T,N,AA} = AA |
|
|
||
| Base.IndexStyle(::Type{OA}) where {OA<:OffsetArray} = IndexStyle(parenttype(OA)) | ||
| parenttype(::Type{OffsetArray{T,N,AA,I}}) where {T,N,AA,I} = AA | ||
| parenttype(::Type{OffsetArray{T,N,AA}}) where {T,N,AA} = AA |
There was a problem hiding this comment.
Also this method is redundant
Suggested change
| parenttype(::Type{OffsetArray{T,N,AA}}) where {T,N,AA} = AA |
|
|
||
| Base.strides(A::OffsetArray) = strides(parent(A)) | ||
| Base.elsize(::Type{OffsetArray{T,N,A,I}}) where {T,N,A,I} = Base.elsize(A) | ||
| Base.elsize(::Type{OffsetArray{T,N,A}}) where {T,N,A} = Base.elsize(A) |
There was a problem hiding this comment.
Other redundant method
Suggested change
| Base.elsize(::Type{OffsetArray{T,N,A}}) where {T,N,A} = Base.elsize(A) |
| # something similar also holds for OffsetUnitRange{BigInt} | ||
| # We may replace the former with the latter in an indexing operation to obtain a performance boost | ||
| @inline function Base.to_index(r::OffsetUnitRange{<:Union{Int,BigInt}}) | ||
| @inline function Base.to_index(r::OffsetUnitRange{<:Union{Integer,BigInt}}) |
There was a problem hiding this comment.
BigInt <: Integer
Suggested change
| @inline function Base.to_index(r::OffsetUnitRange{<:Union{Integer,BigInt}}) | |
| @inline function Base.to_index(r::OffsetUnitRange{<:Integer}) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is trying to solve #370. This is just an initial proposal, but I guess there is a lot of work to do still.
I have noticed that
so I had to manually change some tests when the offsets are
BigIntsAny suggestion or comment is more than welcome as I am not very sure about downstream implications of this PR