Add Integer type annotation to sizehint! overloads
#155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuliaLang/julia#59168 changed the base signature of `sizehint` to use `::Integer` instead of `::Any` for the second argument, thus packages also overload against the signature instead in order to avoid method ambiguity error.
|
Do we want a new release with this too? |
|
I don't think a new release is necessary (the upstream PR was changed to be non-breaking) |
Tokazama
approved these changes
Aug 2, 2025
|
I edited the commit message to reflect the merged state of 59168 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JuliaLang/julia#59168 changed the base signature of
sizehintto use::Integerinstead of::Anyfor the second argument, thus packages also overload against the signature instead in order to avoid method ambiguity error.