Skip to content

Circular reasoning with implicit functions #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gdalle opened this issue Apr 15, 2025 · 1 comment
Open

Circular reasoning with implicit functions #982

gdalle opened this issue Apr 15, 2025 · 1 comment

Comments

@gdalle
Copy link
Contributor

gdalle commented Apr 15, 2025

While working on #980 I noticed something strange in your use of ImplicitDifferentiation. You seem to be using a circular reasoning like the following:

forward(x) = implicit(x)
conditions(x, y, z) = ...
const implicit = ImplicitFunction(forward, conditions)

Can you explain why this is necessary? Higher-order AD perhaps?

@baggepinnen
Copy link
Member

Which set of methods in particular are circular? I think they all accept different type signatures or have subtly different names, e.g., are, arec, ared etc., otherwise the tests would have failed with stack overflow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants