Implement extent checks for point-polygon processes #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should ideally test whether that introduces any bugs.
|
Nice. Got any before/after benchmarks? |
|
Not beyond "keeps running" vs "computation finishes" :D |
|
Finishing is good |
|
@rafaqz would you mind giving this a sense check to see if it makes sense? I'm not 100% firm on how the |
|
@skygering maybe better if you review this if you can, I also don't really know the interface |
|
Is this added elsewhere now? |
|
No, this would just have to be merged as is |
|
I think I was waiting for Skylar to look at this though, maybe we should just merge and have a test case? |
|
I think it's fine |
|
I might merge this too for this release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should ideally test whether that introduces any bugs.