Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typos #234

Open
spaette opened this issue Dec 19, 2024 · 2 comments · May be fixed by #235
Open

typos #234

spaette opened this issue Dec 19, 2024 · 2 comments · May be fixed by #235

Comments

@spaette
Copy link

spaette commented Dec 19, 2024

If these replacement strings look good I will open a PR after the New Year.

Tessellation
Verification
attributes
calculate
conscious
corresponding
containing
dictionary
parallelepiped
primitive
remapped
reset
transform
until
winding

$ grep -nr Tesselation GeometryBasics.jl
GeometryBasics.jl/test/runtests.jl:315:    # @test_warn Tesselation(Rect2f(0, 0, 2, 2), 10)
GeometryBasics.jl/test/runtests.jl:316:    @test Tesselation(Rect2f(0, 0, 2, 2), 10) ==  Tessellation(Rect2f(0, 0, 2, 2), 10)
GeometryBasics.jl/src/interfaces.jl:88:Base.@deprecate_binding Tesselation Tessellation
$ grep -nr Verifaction GeometryBasics.jl
GeometryBasics.jl/test/meshes.jl:122:    @testset "Verifaction" begin
$ grep -nr atttributes GeometryBasics.jl
GeometryBasics.jl/src/meshes.jl:336:mesh that contains no FaceViews, reordering and duplicating vertex atttributes
$ grep -nr calcalute GeometryBasics.jl
GeometryBasics.jl/src/interfaces.jl:38:    # Overload normals(primitive::YourPrimitive), to calcalute the normals
$ grep -nr concious GeometryBasics.jl
GeometryBasics.jl/docs/src/primitives.md:136:Here we should be concious of the winding direction of faces.
$ grep -nr correspondering GeometryBasics.jl
GeometryBasics.jl/src/meshes.jl:137:`pointtype`, `facetype` and `uvtype` are set by the correspondering keyword arguments.
GeometryBasics.jl/src/meshes.jl:157:by the correspondering keyword arguments.
GeometryBasics.jl/src/meshes.jl:178:by the correspondering keyword arguments.
GeometryBasics.jl/src/meshes.jl:195:by the correspondering keyword arguments.
$ grep -nr countaining GeometryBasics.jl
GeometryBasics.jl/src/boundingboxes.jl:8:Construct a bounding box countaining all the given points.
$ grep -nr dictionairy GeometryBasics.jl
GeometryBasics.jl/src/basic_types.jl:629:Returns a dictionairy containing the vertex attributes of the given mesh.
$ grep -nr prallelepiped GeometryBasics.jl
GeometryBasics.jl/docs/src/primitives.md:135:The faces of a prallelepiped are parallelograms, which we can describe with `QuadFace`.
$ grep -nr primtive GeometryBasics.jl
GeometryBasics.jl/src/interfaces.jl:130:Dependent on the given type, extracts data from the primtive and converts its
$ grep -nr remmaped GeometryBasics.jl
GeometryBasics.jl/src/meshes.jl:420:    # keep track of the remmaped indices for one vertex so we don't have to
$ grep -nr resest GeometryBasics.jl
GeometryBasics.jl/src/triangulation.jl:171:            #= resest error detection counter =#
$ grep -nr tranform GeometryBasics.jl
GeometryBasics.jl/src/primitives/rectangles.jl:219:    # make sure our points are sized for the tranform
GeometryBasics.jl/src/primitives/rectangles.jl:224:    # tranform all points, tracking min and max points
GeometryBasics.jl/src/primitives/rectangles.jl:242:    # make sure our points are sized for the tranform
GeometryBasics.jl/src/primitives/rectangles.jl:246:    # tranform all points, tracking min and max points
GeometryBasics.jl/src/primitives/rectangles.jl:265:    # make sure our points are sized for the tranform
GeometryBasics.jl/src/primitives/rectangles.jl:271:    # tranform all points, tracking min and max points
$ grep -nr untill GeometryBasics.jl
GeometryBasics.jl/src/viewtypes.jl:63:Between each polytope, `skip` elements are skipped untill the next starts.
$ grep -nr windig GeometryBasics.jl
GeometryBasics.jl/docs/src/primitives.md:138:For example GeometryBasics normal generation and OpenGL's backface culling assume a counter-clockwise windig direction to correspond to a front-facing face.
$ 

This grepped for string could begin also with an uppercase character.

$ grep -nr cartesian GeometryBasics.jl
GeometryBasics.jl/src/primitives/rectangles.jl:6:Formally it is the cartesian product of intervals, which is represented by the
GeometryBasics.jl/src/primitives/rectangles.jl:20:A rectangle in N dimensions, formally the cartesian product of intervals. See also [`HyperRectangle`](@ref). Its aliases are
$ 
@ffreyer
Copy link
Collaborator

ffreyer commented Dec 19, 2024

The "Tesselation" cases look like they're just the deprecation + test. Those should stay. The rest look like real typos/mistakes to me. Would be good to fix those

@spaette
Copy link
Author

spaette commented Dec 20, 2024

deprecation + test

FWIW, commenting on this section has a link to an Issue.

$ sed -n '313,317p' GeometryBasics.jl/test/runtests.jl
@testset "Deprecations" begin
    # https://github.com/JuliaLang/julia/issues/38780
    # @test_warn Tesselation(Rect2f(0, 0, 2, 2), 10)
    @test Tesselation(Rect2f(0, 0, 2, 2), 10) ==  Tessellation(Rect2f(0, 0, 2, 2), 10)
end
$ 

@spaette spaette linked a pull request Dec 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants