Skip to content

Revert "Add custom subtypes function to avoid deprecation warnings" #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

KristofferC
Copy link
Member

Reverts #236

The added function hangs on 1.12 and the comment to it says

f it starts to cause problems in future version of Julia, it can be removed without any issues

So let's remove it.

Copy link

codecov bot commented Mar 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.43%. Comparing base (56a19bb) to head (120ba24).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #239      +/-   ##
==========================================
- Coverage   69.73%   68.43%   -1.31%     
==========================================
  Files           3        3              
  Lines         456      434      -22     
==========================================
- Hits          318      297      -21     
+ Misses        138      137       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KristofferC KristofferC merged commit dee1a33 into master Mar 24, 2025
7 checks passed
@KristofferC KristofferC deleted the revert-236-subtypes_for_deprecated branch March 24, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant