Upgrade TaylorSeries to v0.18 and TaylorIntegration to v0.16 #171

lbenet · 2024-08-03T03:43:50Z

No description provided.

github-actions · 2024-08-04T01:43:40Z

Pull Request Test Coverage Report for Build 10232509876

Details

353 of 434 (81.34%) changed or added relevant lines in 2 files are covered.
487 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-26.7%) to 53.426%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/valid_integ/validated_integ2.jl	109	142	76.76%
src/valid_integ/validated_integ.jl	244	292	83.56%

Files with Coverage Reduction	New Missed Lines	%
src/validatedODEs.jl	487	0.0%

Totals
Change from base Build 8638389233:	-26.7%
Covered Lines:	1037
Relevant Lines:	1941

💛 - Coveralls

coveralls · 2024-08-04T01:48:54Z

Pull Request Test Coverage Report for Build 10232509876

Details

353 of 434 (81.34%) changed or added relevant lines in 2 files are covered.
487 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-26.3%) to 53.786%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/valid_integ/validated_integ2.jl	109	142	76.76%
src/valid_integ/validated_integ.jl	244	292	83.56%

Files with Coverage Reduction	New Missed Lines	%
src/validatedODEs.jl	487	0.0%

Totals
Change from base Build 8638389233:	-26.3%
Covered Lines:	1037
Relevant Lines:	1928

💛 - Coveralls

coveralls · 2024-08-04T01:48:54Z

Pull Request Test Coverage Report for Build 12995972981

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

355 of 434 (81.8%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-2.1%) to 78.054%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/valid_integ/validated_integ2.jl	109	142	76.76%
src/valid_integ/validated_integ.jl	246	292	84.25%

Totals
Change from base Build 8638389233:	-2.1%
Covered Lines:	1035
Relevant Lines:	1326

💛 - Coveralls

lbenet · 2024-08-15T17:09:01Z

Closes #159 and #160

lbenet · 2024-08-15T17:21:40Z

The test that fails (only in Julia 1.6) is related to an ambiguity detected by Aqua; I'll ignore it for the time being...

schillic · 2024-08-15T17:25:08Z

Closes #159 and #160

FYI, if you want to auto-close these PRs, you need to put this text in the very first post. And GitHub does not understand "and", so you need to write "Closes" twice.

lbenet · 2024-08-15T17:39:47Z

Closes #159 and #160

FYI, if you want to auto-close these PRs, you need to put this text in the very first post. And GitHub does not understand "and", so you need to write "Closes" twice.

Thanks a lot for clarifying it!

.github/workflows/ci.yml

lbenet · 2025-01-27T17:22:42Z

Mmmm, there seems to be some odity related to coveralls...

schillic · 2025-01-27T17:30:51Z

Mmmm, there seems to be some odity related to coveralls...

I have no experience with coveralls (we always use codecov). The error message is indeed not helpful.

Fixing the cause would of course be better, but maybe you can add the following line inside the with block here:

TaylorModels.jl/.github/workflows/ci.yml

Lines 52 to 55 in bfc5791

    
           - uses: coverallsapp/github-action@master 
        
             with: 
        
               path-to-lcov: lcov.info 
        
               github-token: ${{ secrets.GITHUB_TOKEN }}

fail_ci_if_error: false

lbenet · 2025-03-31T03:26:21Z

@schillic I think this is ready to be merged (and tagged). Could you check that everything works fine wrt ReachabilityAnalysis ?

schillic · 2025-03-31T13:03:39Z

I got an error:

pkg> st
[...]
  [92b13dbe] TaylorIntegration v0.16.2
  [314ce334] TaylorModels v0.7.1 `https://github.com/JuliaIntervals/TaylorModels.jl.git#lb/upgrade_TS`
⌅ [6aa5eb33] TaylorSeries v0.18.4
[...]

pkg> test
[...]
  MethodError: no method matching _evaluate!(::TaylorN{IntervalArithmetic.Interval{Float64}}, ::HomogeneousPolynomial{IntervalArithmetic.Interval{Float64}}, ::Tuple{TaylorN{Float64}, TaylorN{Float64}}, ::Vector{TaylorN{Float64}}, ::TaylorN{IntervalArithmetic.Interval{Float64}})
  The function `_evaluate!` exists, but no method is defined for this combination of argument types.
  
  Closest candidates are:
    _evaluate!(::TaylorN{T}, ::HomogeneousPolynomial{T}, ::Int64, ::TaylorN{T}, ::TaylorN{T}) where T<:Union{Real, Complex, Taylor1}
     @ TaylorSeries ~/.julia/packages/TaylorSeries/Mdt5d/src/evaluate.jl:406
    _evaluate!(::TaylorN{T}, ::HomogeneousPolynomial{T}, ::NTuple{N, var"#s485"} where var"#s485"<:TaylorN{T}, ::Array{TaylorN{T}, 1}, ::TaylorN{T}) where {N, T<:Union{Real, Complex}}
     @ TaylorSeries ~/.julia/packages/TaylorSeries/Mdt5d/src/evaluate.jl:197
    _evaluate!(::TaylorN{T}, ::NTuple{N, TaylorN{T}}, ::TaylorN{T}, ::Array{TaylorN{T}, 1}, ::TaylorN{T}) where {N, T<:Number}
     @ TaylorSeries ~/.julia/packages/TaylorSeries/Mdt5d/src/evaluate.jl:501

schillic · 2025-03-31T13:04:00Z

Project.toml

-TaylorIntegration = "0.15"
-TaylorSeries = "0.17"
+TaylorIntegration = "0.16"
+TaylorSeries = "0.18.4"


Did you have to go directly to TaylorSeries = "0.18.4" or could you also go to TaylorSeries = "0.18"?

I think you need to upgrade to TS v0.18.4...

But I'm not completely sure

schillic · 2025-03-31T21:34:38Z

Do you need an input to debug or is it clear what causes the problem?

lbenet · 2025-03-31T22:27:27Z

I'll have a look to see if I can reproduce the problem...

lbenet · 2025-04-01T16:15:52Z

@schillic I can reproduce the error; can you tell me which was the last version (of TS) that allowed the tests to pass. Perhaps the reason for the problem is that I forgot to include a method that is precisely needed here.

schillic · 2025-04-01T16:21:00Z

This branch only allows v0.18.4.
And the last release allows v0.17.8, for which tests passed.

lbenet · 2025-04-01T18:28:30Z

I think I found the problem... Can you test again using for TS the branch in JuliaDiff/TaylorSeries.jl#378 ? (Locally, tests pass, but I prefer to have your confirmation.)

lbenet · 2025-04-01T21:23:42Z

@schillic I juste merged JuliaDiff/TaylorSeries.jl#378; bumping the patch version is on its way. Once that is done, I think I can merge this PR

schillic · 2025-04-01T21:48:32Z

I was too slow debugging something else, but now I re-ran the tests with your branch and indeed they pass 👍

lbenet · 2025-04-01T21:55:57Z

Thanks a lot Christian! I guess I have to tag a minor version, right?

lbenet marked this pull request as ready for review August 3, 2024 23:52

lbenet mentioned this pull request Aug 3, 2024

Update Taylor* packages JuliaReach/ReachabilityAnalysis.jl#856

Merged

lbenet force-pushed the lb/upgrade_TS branch from ed38f1b to 90f39da Compare August 4, 2024 01:38

lbenet force-pushed the lb/upgrade_TS branch from ce7dd20 to e688474 Compare August 4, 2024 01:57

lbenet force-pushed the lb/upgrade_TS branch from 2277969 to a2ee39e Compare August 17, 2024 04:29

schillic reviewed Jan 27, 2025

View reviewed changes

.github/workflows/ci.yml Show resolved Hide resolved

schillic mentioned this pull request Jan 27, 2025

bumped taylor series version #174

Closed

lbenet added 11 commits January 27, 2025 12:52

Upgrade TS ans TI, and minor fixes

6a12f2a

Add tests: integrate x^3 and check finiteness of remainder

db31fb8

Upgrade TI to v0.16.0, and shorten validated integration code

5e5a936

Remove validatedODEs.jl

583a905

Update ci

dfb7e42

Fix ci

8d5267d

Cleaning up

39fa3d7

Add xdot = -x^3 tests

1145167

Test (CI) lts, 1 and nightly

076b170

Fix minimal compat julia version to 1.10

c9cdde2

Use one thread for CI

7f79de7

lbenet force-pushed the lb/upgrade_TS branch from 2bef1f1 to 7f79de7 Compare January 27, 2025 18:52

New methods in evaluate, fixes in recipes, and tests

39c0a5b

schillic reviewed Mar 31, 2025

View reviewed changes

Bump minor version

fead504

lbenet merged commit bcca0bb into master Apr 1, 2025
12 checks passed

lbenet deleted the lb/upgrade_TS branch April 1, 2025 23:26

Upgrade TaylorSeries to v0.18 and TaylorIntegration to v0.16 #171

Upgrade TaylorSeries to v0.18 and TaylorIntegration to v0.16 #171

Uh oh!

Conversation

lbenet commented Aug 3, 2024

Uh oh!

github-actions bot commented Aug 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 10232509876

Details

💛 - Coveralls

Uh oh!

coveralls commented Aug 4, 2024

Pull Request Test Coverage Report for Build 10232509876

Details

💛 - Coveralls

Uh oh!

coveralls commented Aug 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 12995972981

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

Uh oh!

lbenet commented Aug 15, 2024

Uh oh!

lbenet commented Aug 15, 2024

Uh oh!

schillic commented Aug 15, 2024

Uh oh!

lbenet commented Aug 15, 2024

Uh oh!

Uh oh!

lbenet commented Jan 27, 2025

Uh oh!

schillic commented Jan 27, 2025

Uh oh!

lbenet commented Mar 31, 2025

Uh oh!

schillic commented Mar 31, 2025

Uh oh!

schillic Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

lbenet Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

lbenet Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

schillic commented Mar 31, 2025

Uh oh!

lbenet commented Mar 31, 2025

Uh oh!

lbenet commented Apr 1, 2025

Uh oh!

schillic commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lbenet commented Apr 1, 2025

Uh oh!

lbenet commented Apr 1, 2025

Uh oh!

schillic commented Apr 1, 2025

Uh oh!

lbenet commented Apr 1, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 4, 2024 •

edited

Loading

coveralls commented Aug 4, 2024 •

edited

Loading

schillic commented Apr 1, 2025 •

edited

Loading