Skip to content

Compatibility with IA-1.0 #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Compatibility with IA-1.0 #178

wants to merge 12 commits into from

Conversation

lbenet
Copy link
Member

@lbenet lbenet commented May 6, 2025

No description provided.

@Kolaru
Copy link

Kolaru commented May 18, 2025

I had done some work on this as well, mostly through search and replace through the whole repository.

I have merge the two version and put it in the kolaru_IA1.0 branch. You may consider integrating to this one if you thing it is helpful (I don't have time to look in more detail for now).

The main difference is that:

  • I use SVector internally for the models, and still parametrize the type on its length
  • I used AbstractVector{<:Interval} to replace IntervalBox where possible

@lbenet
Copy link
Member Author

lbenet commented May 18, 2025

Thanks Benoît for the efforts and the ideas; I like both of them. Currently, I'm now in the "validated" integration part, which I am moving to a submodule (it is sort of a separate thing), so if you want to push your suggestions, please do so.

@lbenet
Copy link
Member Author

lbenet commented May 18, 2025

(I can also incorporate them, whenever I also find the time.)

@Kolaru
Copy link

Kolaru commented May 25, 2025

I have added my changes. There are some tests failing that I don't have time to look at right now, but (normally) I fixed all type errors.

@lbenet
Copy link
Member Author

lbenet commented May 26, 2025

Thanks a lot @Kolaru for including your changes; I'll take some time tomorrow (or the day after) to see what happens with the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants