Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename result_0 to result in dialect ops bindings #83

Open
mofeing opened this issue Nov 30, 2024 · 0 comments
Open

Rename result_0 to result in dialect ops bindings #83

mofeing opened this issue Nov 30, 2024 · 0 comments

Comments

@mofeing
Copy link
Member

mofeing commented Nov 30, 2024

Right now, ops with result_0 kwarg put it like that because they either have multiple results or name it like that in the defining tblgen.

We haven't found any case of result_1 or higher, and for the multiple results a tuple of MLIR.IR.Types could be passed instead. What do you think @jumerckx? should we rename it?

I think it would make calling the interface to ops a lil bit more pleasant and less error-prone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant