Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up syntax.jl tests in Base so that JuliaSyntax can test the non-controversial parts. #533

Open
KristofferC opened this issue Feb 4, 2025 · 0 comments

Comments

@KristofferC
Copy link
Member

Right now, the syntax.jl tests are skipped (

# syntax.jl has some intentionally weird syntax which we parse
# differently than the flisp parser, and some cases which we've
# decided are syntax errors.
if endswith(f, "syntax.jl")
return nothing
end
). However, this causes us to sometimes regress, see e.g. https://github.com/JuliaLang/julia/pull/57188/files#diff-266674e240feff7742a800c1c360befe28cd7a20f49dada34fef94a122acd90b where the test got changed and then caused regressions JuliaLang/julia#57223.

It would probably be a good idea to split up syntax.jl into a "controversial" part which is not tested by JuliaSyntax and a standard part which does get tested. Ideally, as time moves on the controversial part is shrunk.

@KristofferC KristofferC changed the title Run syntax.jl tests Split up syntax.jl tests in Base so that JuliaSyntax can test the non-controversial parts. Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant