Bug: Juliaup doesn't clean up `.bashrc` when encountering an error

[xijiang]

When installing juliaup on new system

curl -fsSL https://install.julialang.org | sh

Well, this is embarrassing.

Juliainstaller had a problem and crashed. To help us diagnose the problem you can send us a crash report.

We have generated a report file at "/tmp/report-6632abb7-be4b-4fe5-b239-e53be0f955d3.toml". Submit an issue or email with the subject of "Juliainstaller Crash Report" and include the report as an attachment.


To submit the crash report:

https://github.com/JuliaLang/juliaup

We take privacy seriously, and do not perform any automated error collection. In order to improve the software, we rely on people to submit reports.

Thank you kindly!

name = "Juliainstaller"
operating_system = "Fedora 42.0.0 [64-bit]"
crate_version = "1.18.0"
explanation = """
Panic occurred in file 'src/operations.rs' at line 1336
"""
cause = """
called `Result::unwrap()` on an `Err` value: Error occured while searching juliaup shell startup script section in /home/xijiang/.bashrc

Caused by:
    Found an opening marker but no end marker of juliaup section."""
method = "Panic"
backtrace = """
   0:     0x7fa44396469d - human_panic::handle_dump::h704c9125fb0ae70c
   1:     0x7fa443874df7 - human_panic::setup_panic::{{closure}}::ha88cb9427ec5fbe9
   2:     0x7fa443b92db4 - std::panicking::rust_panic_with_hook::hd0181d9520c1e3af
   3:     0x7fa443bca688 - std::panicking::begin_panic_handler::{{closure}}::h38f4891d88a96057
   4:     0x7fa443bca5e9 - std::sys::backtrace::__rust_end_short_backtrace::hc8c3bb4b88b42e7b
   5:     0x7fa443bcd45c - __rustc[5224e6b81cd82a8f]::rust_begin_unwind
   6:     0x7fa443853ddf - core::panicking::panic_fmt::hf183afc3dfc6cb4e
   7:     0x7fa4438542a5 - core::result::unwrap_failed::h87fb80eab4577677
   8:     0x7fa4439db27e - juliaup::command_config_modifypath::run_command_config_modifypath::h9981e81f017f8db7
   9:     0x7fa4438945ca - juliainstaller::main::h9eef85a6619d4dec
  10:     0x7fa44387bef3 - std::sys::backtrace::__rust_begin_short_backtrace::hc7e58f79c22634cf
  11:     0x7fa44389a9a5 - main
"""

This can be manually corrected:

juliaup add 1.11
cd ~/.juliaup/bin
ln -s julialauncher julia

But still annoying.
Regards

[xijiang]

my .bashrc

# .bashrc

# Source global definitions
if [ -f /etc/bashrc ]; then
    . /etc/bashrc
fi

# User specific environment
if ! [[ "$PATH" =~ "$HOME/.local/bin:$HOME/bin:" ]]; then
    PATH="$HOME/.local/bin:$HOME/bin:$PATH"
fi
export PATH

# User specific aliases and functions
if [ -d ~/.bashrc.d ]; then
    for rc in ~/.bashrc.d/*; do
        if [ -f "$rc" ]; then
            . "$rc"
        fi
    done
fi
unset rc
#... some other lines
# !! Contents within this block are managed by juliaup !!

# <<< juliaup initialize <<<
case ":$PATH:" in
    *:/home/xijiang/.juliaup/bin:*)
        ;;

    *)
        export PATH=/home/xijiang/.juliaup/bin${PATH:+:${PATH}}
        ;;
esac

[DilumAluthge]

Can you delete everything from # <<< juliaup initialize <<< to the end of the file, and then try to install Juliaup again?

I do think that this is a Juliaup bug; Juliaup should cleanup after itself if it encounters an error during the installation process.

[xijiang]

Yes this solved the problem. You may close this or add a few lines of codes to deal with the .bashrc file.
Many thanks

[DilumAluthge]

I'll leave this issue open for now. I think it would be nice if Juliaup cleaned up gracefully in this kind of situation.