Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of array indexing calls [] #212

Closed
2 of 6 tasks
chiyahn opened this issue Jul 17, 2018 · 3 comments · Fixed by #226
Closed
2 of 6 tasks

Deprecation of array indexing calls [] #212

chiyahn opened this issue Jul 17, 2018 · 3 comments · Fixed by #226

Comments

@chiyahn
Copy link
Contributor

chiyahn commented Jul 17, 2018

As suggested in #206 (comment), I propose the following procedural changes to deprecate interpolation evaluation by array indexing []:

  • Support interpolation evaluation by function calls () (complete from Function call syntax support #206)
  • ModifyREADME.md to let users know that [] is deprecated in favour of () (complete from Function call syntax support #206)
  • Start throwing deprecation warnings for evaluation with []
  • Modify unit tests and files in doc directory that evaluate interpolation objects by [] to ()
  • Modify any script in package that evaluates interpolation objects by [] to ()
  • (After tagging a major release) remove [] from the code base entirely

The first two steps will be completed as soon as the pull request #206 is approved and changes are committed accordingly. Completing the rest of the procedure should not be a complex task.

@tomasaschan
Copy link
Contributor

tomasaschan commented Jul 17, 2018

Nice! I suggest adding to the to do-list also the following actions:

  • start throwing depreciation warnings for evaluation with []
  • (after tagging a major release) remove [] from the code base entirely

@chiyahn
Copy link
Contributor Author

chiyahn commented Jul 18, 2018

No problem, just added them to the list!

@timholy timholy mentioned this issue Aug 11, 2018
7 tasks
@timholy timholy mentioned this issue Aug 22, 2018
4 tasks
@lstagner
Copy link

lstagner commented Sep 7, 2018

Instead of removing [] syntax entirely would it be possible to just have it used for accessing the underlying value array i.e. itp[i] == itp(x[i])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants