Hash USER environment variable during system_uuid fallback#587
Merged
jpsamaroo merged 1 commit intoJuliaParallel:masterfrom Feb 1, 2025
Merged
Hash USER environment variable during system_uuid fallback#587jpsamaroo merged 1 commit intoJuliaParallel:masterfrom
USER environment variable during system_uuid fallback#587jpsamaroo merged 1 commit intoJuliaParallel:masterfrom
Conversation
Contributor
Author
|
Ah actually the docs mention that the hash may change when a new process is started. I'm not entirely sure if that is an issue here, because the workers should be started before Dagger is loaded according to the docs. I also wasn't able to locally produce different hashes for the same value |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently encountered a system where the
USERenvironment variable got set to "domain/user". Such a name then gets interpreted as a filepath which breaks thesystem_uuid_fallbacklogic.As a workaround this PR hashes the variable before using it in the filepath creation. Same user names should still result in the same hash values