Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The user should be able to choose the "unit" of waveforms. #284

Open
schustermartin opened this issue Apr 20, 2022 · 0 comments
Open

The user should be able to choose the "unit" of waveforms. #284

schustermartin opened this issue Apr 20, 2022 · 0 comments
Labels
convenience Improve user-friendliness enhancement Improvement of existing features
Milestone

Comments

@schustermartin
Copy link
Collaborator

While I agree that it is correct that we simulate the actual induced charge on the preamplifiers and it does e.g. influence the number of charges in the charge cloud, I think in many use-case scenarios it is an unnecessary complication to manually multiply the output waveform with the corresponding E_ionisation, to obtain a "calibrated" pulse. This could be integrated into SSD.

One solution would be introducing a keyword to the get_signals! function, e.g. calibrated = true.
Then SSD would return e.g. 100 keV pulse for a 100 keV energy deposition, while still handling things correctly under the hood.

An alternate name for the keyword could be unit = :energy or :charge, respectively. Thoughts?

@schustermartin schustermartin added enhancement Improvement of existing features convenience Improve user-friendliness labels Apr 20, 2022
@fhagemann fhagemann added this to the v0.10.0 milestone Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
convenience Improve user-friendliness enhancement Improvement of existing features
Projects
None yet
Development

No branches or pull requests

2 participants