Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GR backend: use textext for :log2 and :ln axis scaling #4991

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

pjaap
Copy link
Contributor

@pjaap pjaap commented Sep 27, 2024

This fixes #4871

Only the case of :log10 has been treated before.

Description

Attribution

Things to consider

  • Does it work on log scales?
  • Does it work in layouts?
  • Does it work in recipes?
  • Does it work with multiple series in one call?
  • PR includes or updates tests?
  • PR includes or updates documentation?

This fixes JuliaPlots#4871

Only the case of :log10 has been treated before.
@pjaap
Copy link
Contributor Author

pjaap commented Sep 27, 2024

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.14%. Comparing base (fa65e7d) to head (a08a88c).
Report is 26 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4991      +/-   ##
==========================================
- Coverage   89.77%   87.14%   -2.63%     
==========================================
  Files          40       41       +1     
  Lines        8780     9081     +301     
==========================================
+ Hits         7882     7914      +32     
- Misses        898     1167     +269     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeastyBlacksmith
Copy link
Member

Should this go into master an/or v2 branch?

Ideally both

@pjaap
Copy link
Contributor Author

pjaap commented Sep 30, 2024

Ok, sure. Then I'll open another PR for v2 once this is merged. What needs to be done to get this here merged?

@BeastyBlacksmith BeastyBlacksmith merged commit b50b774 into JuliaPlots:master Sep 30, 2024
13 of 16 checks passed
pjaap added a commit to pjaap/Plots.jl that referenced this pull request Sep 30, 2024
This fixes JuliaPlots#4871

Only the case of :log10 has been treated before.
@pjaap
Copy link
Contributor Author

pjaap commented Sep 30, 2024

Thanks for merging. The other one is #4993

@BeastyBlacksmith
Copy link
Member

Thanks for contributing!

BeastyBlacksmith pushed a commit that referenced this pull request Oct 2, 2024
This fixes #4871

Only the case of :log10 has been treated before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants