Skip to content

Actually use lookback in usage example #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

LilithHafner
Copy link
Member

As far as I can tell, as written, the example usage asks the user for a lookback number but doesn't pass it to the actual workflow. Is that the case? And if so, would this fix it?

@fingolfin
Copy link
Contributor

No this is not correct. The passed lookback value is used by TagBot. E.g. I successfully used it to pass a lookback of 450 days in this log.

Here is a run for the https://github.com/JuliaCollections/AbstractTrees.jl repository with a default lookback of 3, which failed to find several missing releases

And here I've run it again with a lookback of 900 to find the two missing releases -- unfortunately it seems to struggle with this (been running for two hours now) but I think it is enough to demonstrate that the lookback is passed on...

All in all I have no doubts that the lookback input does have an effect.

As to why it works, my guess is that this is because the get_input helper function in TagBot parses its inputs from the file pointed to by GITHUB_EVENT_PATH. At least I interpret https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#providing-inputs as perhaps saying that the workflow dispatch inputs are mirrored that. But (as usual) the GitHub docs are too vague to know without trial and error. Alas, since it works demonstrably, I personally won't spend further time on researching this.

@LilithHafner
Copy link
Member Author

Hm, interesting that both the logs you shared have the line lookback: 3 in them. But I guess if it works it works 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants