Skip to content

Update CI.yml to include mac aarch64 #1856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2024
Merged

Update CI.yml to include mac aarch64 #1856

merged 1 commit into from
May 19, 2024

Conversation

ViralBShah
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.96%. Comparing base (b09dcd7) to head (04c7bf6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1856   +/-   ##
=======================================
  Coverage   85.96%   85.96%           
=======================================
  Files         144      144           
  Lines        8647     8647           
=======================================
  Hits         7433     7433           
  Misses       1214     1214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ViralBShah ViralBShah merged commit f852803 into master May 19, 2024
12 of 16 checks passed
@ViralBShah ViralBShah deleted the vs/mac-aarch64-ci branch May 19, 2024 16:38
@devmotion
Copy link
Member

If I understand correctly, this change was unnecessary because recently Github updated macos-latest to point to macos-14 which is arm64 exclusive: actions/runner-images#9255 This can be seen from the CI logs as well, the existing macos job already runs on arm64: https://github.com/JuliaStats/Distributions.jl/actions/runs/9144982709/job/25143434782#step:1:8

@ViralBShah
Copy link
Contributor Author

ViralBShah commented May 19, 2024

Oh I didn't realize that they had updated that. I'll revert this.

But I just noticed something that I can't quite understand. The one that I added macOS-14, is specifically pulling Julia for aarch64 (https://github.com/JuliaStats/Distributions.jl/actions/runs/9144982709/job/25143435277#step:3:4), whereas the macOS-latest you pointed me to appears to be pulling in Julia for x64, even though the runner image is aarch64 (https://github.com/JuliaStats/Distributions.jl/actions/runs/9144982709/job/25143434782#step:3:4).

It looks like macOS-14 seems to have support for both aarch64 and x64. The thing that is puzzling is that our matrix says x64, the mac runner is aarch64, setup-julia pulls the x64 binary, and then it seems to work in the CI.

cc @DilumAluthge @IanButterworth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants