What should I implement?

i.e. What should be tested and semantics of already defined terms.

Piracy

Adding more functions / methods with an extension does not remove any type piracy.
-> Only test with all extensions loaded.
Extensions may behave exactly as the base package (w.r.t. ownership)

If one considers PlottingContourExt as a completely separate package, it could be argued that defining Plotting.plot(c::Contour.ContourCollection) is type piracy since PlottingContourExt owns neither the method Plotting.plot nor the type Contour.ContourCollection. However, for extensions, it is ok to assume that the extension owns the methods in its parent package. In fact, this form of type piracy is one of the most standard use cases for extensions.
Source

Functions only occurring in an extension (and not in the base package) should be considered as well, as they may pirate some dependency.

Ambiguities

Adding dependencies and/or extensions may lead to more ambiguities.
-> Add all weakdeps needed for a given extension all at once.
If a package has $n$ extensions, each of the $2^n$ combinations of extensions may have different ambiguities.
-> Choose some defaults and give the user the possibility to add additional combinations.

As a default, I propose the following $n+2$ combinations:

no extensions, only the base package
all extensions
for each extension, only add that single extension

This should cover most cases, while still only needing a linear number of testruns.

What do you think @aplavin @fingolfin? In particular about the defaults for ambiguities?

Check for piracy and ambiguity in extensions #160

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions