-
Notifications
You must be signed in to change notification settings - Fork 15
add support for Sixel #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Sixel actually adds a 50 direct dependencies, including ImageCore, which we currently use a hack to avoid depending on directly. If we are depending on it directly, i think we don't need to use a enviroment variable to decide if to use it or not, and can just use |
|
Unfortunately that returns false inside the Pkg.test worker in a local terminal where it otherwise returns true. |
|
Oh thats annoying we should open an issue on Sixel.jl about that |
|
Attempts to fix it here JuliaIO/Sixel.jl#29 Pkg discussion about it here JuliaLang/Pkg.jl#3185 (comment) |
|
I really want this and I'm fine with setting an env variable to get it FWIW. |
|
I propose the following things:
|
|
Please feel free to take this over. It's not a high priority for me right now. |
|
@MasonProtter are you interested in doing these things? |
|
Yeah I can look into it during the week. Ill let you know the if I can take it on. |
I think this is ok as a direct dep?
Also, needs testing.
If
REFERENCETESTS_SIXEL=1