Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop pre-1.6 support #78

Open
mmiller-max opened this issue Dec 1, 2021 · 3 comments
Open

Drop pre-1.6 support #78

mmiller-max opened this issue Dec 1, 2021 · 3 comments

Comments

@mmiller-max
Copy link
Member

Although this seems a bit drastic, I think this will let us tidy up the code significantly. It's become a bit unwieldy and testing/developing is not as seamless as it could be, and it would be good to simplify the code to make maintenance more easy going forward.

@oxinabox
Copy link
Member

oxinabox commented Dec 2, 2021

yep, can always backport changed

@mmiller-max
Copy link
Member Author

How would version numbers work with back porting? Would we need to bump the minor number when dropping pre v1.6 so we could keep incrementing the patch for backports, even though dropping support wouldn't be a breaking change?

@oxinabox
Copy link
Member

oxinabox commented Dec 4, 2021

Yes we would need to do that.
But let's just release 1.0 when we drop pre-1.6 support.
I think it is time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants