Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to sort out typings issues when updating all core dependencies #27

Open
JulianCataldo opened this issue Oct 2, 2023 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@JulianCataldo
Copy link
Owner

JulianCataldo commented Oct 2, 2023

After doing a nuclear pnpm up --latest:

It works well with no regressions during runtime.
But sadly a lot of typings broke into havoc for major semver bumps.
I still have to wrap my head around various API changes for unified and friends deps. before publishing an update for this plugin, with 100% correct internal types.

I can't focus on this right now, but it's in my scope. As for now, this plugin is doing its duty, even with latest the remark versions.
In the meantime, any help will be appreciated!

@JulianCataldo JulianCataldo changed the title Need to sort out typings issue when updating all core dependencies Need to sort out typings issues when updating all core dependencies Oct 2, 2023
@JulianCataldo
Copy link
Owner Author

Faulty deps. remaining:

 @types/mdast   3.0.13  →   4.0.1
 @types/unist    2.0.8  →   3.0.0
 unified        10.1.2  →  11.0.3
 vfile-message  ^3.1.4  →  ^4.0.2

Everything else has been upgraded.

@JulianCataldo JulianCataldo pinned this issue Oct 16, 2023
@JulianCataldo JulianCataldo added bug Something isn't working help wanted Extra attention is needed labels Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant