uSYnc.Complete v15.1.5.0: sync problems when pulling data types from Umbraco v13 source

[afabri73]

Describe the bug
Hi Kevin,
I need to align a new website (Umbraco v15.3.0) to the current production website (Umbraco v13.7.2).
The problem is on pulling old Data Types into the new website.

Version (please complete the following information):

• Umbraco Version: 15.3.0
• uSync.Complete Version: 15.1.4

To Reproduce

1. First of all I used in Umbraco v13 all datatypes compatible with v15 and removed all non-compatible datatypes (e.g. Umbraco.UmbNav.Web, etc.)
2. I exported all the default datatypes and I see that there are differences between the v13 and v15.

OLD DATATYPE (v13)

<?xml version="1.0" encoding="utf-8"?>
<DataType Key="0e9794eb-f9b5-4f20-a788-93acd233a7e4" Alias="Label (datetime)" Level="1">
  <Info>
    <Name>Label (datetime)</Name>
    <EditorAlias>Umbraco.Label</EditorAlias>
    <DatabaseType>Date</DatabaseType>
  </Info>
  <Config><![CDATA[{
  "ValueType": "DATETIME"
}]]></Config>
</DataType>

NEW DATATYPE (v15)

<?xml version="1.0" encoding="utf-8"?>
<DataType Key="0e9794eb-f9b5-4f20-a788-93acd233a7e4" Alias="Label (datetime)" Level="1">
  <Info>
    <Name>Label (datetime)</Name>
    <EditorAlias>Umbraco.Label</EditorAlias>
    <EditorUIAlias>Umb.PropertyEditorUi.Label</EditorUIAlias>
  </Info>
  <Config><![CDATA[{
  "umbracoDataValueType": "DATETIME"
}]]></Config>
</DataType>

3. Reading the documentation I set the mapping of the properties in CustomMappings settings:

    `"uSync": {
    "Publisher": {
        "Settings": {
            "AppId": "----------------------------",
            "AppKey": "------------------------------",
            "IncludeHost": false,
            "IncomingEnabled": true,
            "MediaPageSize": 5,
            "PageSize": 15,
            "requireAuthentication": true
        }
    },
    "Settings": {
        "BackgroundNotifications": true,
        "CustomMappings": {
            "DatabaseType": "",
            "ValueType": "umbracoDataValueType",
            "FileExtensions": "fileExtensions"
        }
    }
},`

4. When I try to pull datatypes the comparison and the import seems to don't use the new mapping

Expected behavior
For complete compatibility with v15, for example when I pull (or import) the "Label (datetime)" Data Type, I want to not import the "DatabaseType" property (present in the old data type) and the value of "ValueType" property, present in Config, must be put into the new "umbracoDataValueType" property (present in v15)
How can I resolve the problem?

Screenshots
This is an example.
Databasetype property not removed and in Config property, uSync will update the name of the new "umbracoDataValueType" property with the old "ValueType" property

Thank you and I look forward to your reply
Adriano

[KevinJump]

Hi Adriano,

I am not 100% of some of this, which bit of documentation did you find the the "CustomMappings" stuff, really that's intended for when you want a new type to behave like an existing one during the export/import phase and with uSync complete (e.g you might have "My.CustomEditor", "Umbraco.RichText" to say you custom editor has the same data structure as the RichText editor).

uSync v15 has some basic migration stuff built in, so what should happen on import of uSync v13 files is the ConfigurationSerializers do this work for you.

So for example, the LabelMigrationConfigSerializer

In this example the ConfigSerializer swaps the "valueType" to "umbracoDataValueType" as part of the import. (it doesn't do it on disk, buy once it's imported you can then export updated).
There are others, some of them can be more complex, but they are intended to do this property conversion on the fly as the import happens.

there is also a bit of code to get the UI Property editor aliases too: https://github.com/KevinJump/uSync/blob/v15/main/uSync.Core/Serialization/Serializers/DataTypeSerializer.cs#L392

so, if these work as expected you should be able to import thew v13 folder directly and it import using the new values..

because there are differences on disk to in memory, it won't then report no changes if you run again, things will be imported.