fix review comments (#768)

* fix review comments

* fix review comments

* Fixed pip install error

* Fixed reboot RPC error handling

* fix review comments

* fix review comments

* fix review comments

* fixed yamllint error

* v1.0.9 update

* fix for white space error

* fix for TypeError

Author: chidanandpujar

.github/workflows/ansible_lint.yml

@@ -44,7 +44,7 @@ jobs:
       - name: Install ansible-lint from pip
         shell: bash
         run: |
-          pip install ansible-compat==24.10.0 ansible-lint
+          pip install ansible-compat==25.1.1 ansible-lint
           ansible-lint --version
       - name: Run ansible-lint
         shell: bash

ansible_collections/juniper/device/CHANGELOG.rst

@@ -6,6 +6,21 @@ Juniper Device Collection Release Notes
 Changelog for Juniper Device Ansible Collection
 ===========================
 
+Version 1.0.9 (2025-09-23)
+---------------------------
+Enhancements
+------------
+- None
+
+Bugs Fixed
+----------
+- Fixed the Software Installation RPC Error Handling #765
+- Fixed ansible lint issues #752
+- Fixed Ansible Automation Hub certification review comments #766
+- Fixed GitHub workflow minor issues. #751
+- Fixed Incorrect ConnectionError Exception Detection in software.py #770
+- Removed the deprecated Looseversion in Python3.12 and added support for packaging.version #771
+
 Version 1.0.8 (2025-04-30)
 ---------------------------
 Enhancements

ansible_collections/juniper/device/README.md

@@ -69,7 +69,7 @@ This modules requires the following to be installed on the Ansible control machi
 - [jxmlease](https://github.com/Juniper/jxmlease) 1.0.1 or later
 - [xmltodict](https://pypi.org/project/xmltodict/) 0.13.0 or later
 - [jsnapy](https://github.com/Juniper/jsnapy) 1.3.7 or later
-- [looseversion](https://github.com/effigies/looseversion) 1.3.0 or later
+- [packaging](https://github.com/pypa/packaging) 25.0 or later
 
 
 ## Installation
@@ -207,4 +207,4 @@ Juniper Networks is actively contributing to and maintaining this repo. Please c
 
 ## License Information
 
-Apache 2.0
+Apache 2.0

ansible_collections/juniper/device/galaxy.yml

@@ -9,7 +9,7 @@ namespace: juniper
 name: device
 
 # The version of the collection. Must be compatible with semantic versioning
-version: 1.0.8
+version: 1.0.9
 
 # The path to the Markdown (.md) readme file. This path is relative to the root of the collection
 readme: README.md

ansible_collections/juniper/device/meta/runtime.yml

@@ -1 +1 @@
-requires_ansible: ">=2.17.0"
+requires_ansible: ">=2.16.0"

ansible_collections/juniper/device/plugins/connection/pyez.py

@@ -842,7 +842,7 @@ def system_api(
         member_id=None,
     ):
         """Triggers the system calls like reboot, shutdown, halt and zeroize to device."""
-        msg = None
+        msg = ""
         if action != "zeroize":
             if at == "now" or (in_min == 0 and at is None):
                 if self.dev.timeout > 5:
@@ -914,7 +914,7 @@ def software_api(self, install_params):
 
     def reboot_api(self, all_re, vmhost, member_id=None):
         """reboots the device."""
-        msg = None
+        msg = ""
         try:
             restore_timeout = self.dev.timeout
             if self.dev.timeout > 5:

ansible_collections/juniper/device/plugins/module_utils/configuration.py

@@ -35,7 +35,7 @@
 __metaclass__ = type
 
 try:
-    from looseversion import LooseVersion
+    from packaging.version import Version
 
     HAS_LOOSE_VERSION = True
 except ImportError:
@@ -166,7 +166,7 @@ def _check_library(
                 % (library_nickname, library_name, installation_url, library_name)
             )
     elif installed_version is not None and minimum is not None:
-        if not LooseVersion(installed_version) >= LooseVersion(minimum):
+        if not Version(installed_version) >= Version(minimum):
             return (
                 "%s >= %s is required for this module. Version %s of "
                 "%s is currently installed. See %s for details on "

ansible_collections/juniper/device/plugins/modules/software.py

@@ -791,7 +791,7 @@ def main():
                             install_params.get("vmhost"),
                         )
                 except Exception as err:  # pylint: disable=broad-except
-                    if "ConnectionError" in str(type(err)):
+                    if "ConnectionError" in str(err):
                         # If Exception is ConnectionError, it is excpected
                         # Device reboot inititated succesfully
                         junos_module.logger.debug("Reboot RPC executed.")

ansible_collections/juniper/device/requirements.txt

@@ -1,6 +1,5 @@
-ansible >= 2.10
 junos-eznc >= 2.6.0
 jsnapy>=1.3.6
 jxmlease
 xmltodict
-looseversion
+packaging

ansible_collections/juniper/device/tests/integration/targets/junos_config/tests/common/config.yml

@@ -10,7 +10,7 @@
 
 - name: Check TEST 1
   ansible.builtin.assert:
-    that: test1.config
+    that: test1.config is defined
 
 - name: Append .foo to the hostname using private config mode.
   juniper.device.config:
@@ -26,7 +26,8 @@
 - name: Check TEST 2
   ansible.builtin.assert:
     that:
-      - test2.failed == False
+      - test2.diff_lines is defined
+      - test2.diff_lines | length > 0
 
 - name: Rollback to the previous config.
   juniper.device.config:
@@ -39,7 +40,8 @@
 - name: Check TEST 3
   ansible.builtin.assert:
     that:
-      - test3.failed == False
+      - test3.diff_lines is defined
+      - test3.diff_lines | length > 0
 
 - name: Save rescue configuration
   juniper.device.command:
@@ -62,7 +64,8 @@
 - name: Check TEST 4
   ansible.builtin.assert:
     that:
-      - test4.failed == False
+      - test4.diff_lines is defined
+      - test4.diff_lines | length > 0
 
 - name: Clean up TEST 4
   ansible.builtin.file:
@@ -146,4 +149,18 @@
 - name: Check TEST 9
   ansible.builtin.assert:
     that:
-      - test9.failed == False
+      - test2.diff_lines is defined
+      - test2.diff_lines | length > 0
+
+- name: Rollback to the previous config.
+  juniper.device.config:
+    rollback: 1
+  register: test3
+  ignore_errors: true
+  tags: [test3]
+
+- name: Check TEST 3
+  ansible.builtin.assert:
+    that:
+      - test3.diff_lines is defined
+      - test3.diff_lines | length > 0