Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up editing flag configuration properties #1449

Closed
Abrynos opened this issue Jun 23, 2021 · 1 comment · Fixed by #1450
Closed

Speed up editing flag configuration properties #1449

Abrynos opened this issue Jun 23, 2021 · 1 comment · Fixed by #1450
Assignees
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features.

Comments

@Abrynos
Copy link
Member

Abrynos commented Jun 23, 2021

Purpose

Speed up workflow for the user when editing flag-enum configuration properties

Solution

Instead of having to click the Add button every time I want to add a value to a flag enum (e.g. for the config property BotBehaviour) I have to press the add-button. I'd like the value to be automatically added when selecting it from the dropdown.

Alternatives

Do nothing and leave it at two clicks necessary for each value.

@Abrynos Abrynos added ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🧐 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. labels Jun 23, 2021
@Botan626
Copy link
Contributor

Botan626 commented Jun 24, 2021

This issue could be combined with #1442 and dropdown menu could have checkboxes with such structure:
image

Instead of 'Every day' it could have All option and instead of 'Last Weekday in month' it could have None option. And property values instead of days of course. No need for Add button then.

@MrBurrBurr MrBurrBurr added 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial. and removed 🧐 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. labels Jun 28, 2021
@MrBurrBurr MrBurrBurr linked a pull request Jun 28, 2021 that will close this issue
5 tasks
@MrBurrBurr MrBurrBurr removed the 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request. label Jun 29, 2021
MrBurrBurr pushed a commit that referenced this issue Jun 29, 2021
* Implement #1449

* Properly localize newly added text

* Remove done TODO comments

* Remove obsolete methods

* Replace function parameter reassignment with local const

* Change displayed texts casing to match master branch
@MrBurrBurr MrBurrBurr removed the 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial. label Jun 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants