Change null purchase_receipt_info to BadResponse

Author: JustArchi

ArchiSteamFarm/Steam/Bot.cs

@@ -3650,7 +3650,7 @@ private async void RedeemGamesInBackground(object? state = null) {
 					continue;
 				}
 
-				EResult result = EResult.Timeout;
+				EResult result = EResult.BadResponse;
 				EPurchaseResultDetail purchaseResultDetail = EPurchaseResultDetail.NoDetail;
 				string? balanceText = null;
 
@@ -3691,7 +3691,7 @@ private async void RedeemGamesInBackground(object? state = null) {
 						break;
 					case EPurchaseResultDetail.BadActivationCode:
 					case EPurchaseResultDetail.DuplicateActivationCode:
-					case EPurchaseResultDetail.NoDetail: // OK
+					case EPurchaseResultDetail.NoDetail:
 						redeemed = true;
 
 						break;

ArchiSteamFarm/Steam/Interaction/Commands.cs

@@ -2656,7 +2656,7 @@ internal void OnNewLicenseList() {
 									result = EResult.Timeout;
 									purchaseResultDetail = EPurchaseResultDetail.Timeout;
 								} else if (redeemResult.purchase_receipt_info == null) {
-									result = EResult.Timeout;
+									result = EResult.BadResponse;
 									purchaseResultDetail = EPurchaseResultDetail.NoDetail;
 								} else {
 									result = (EResult) redeemResult.purchase_receipt_info.purchase_status;
@@ -2702,7 +2702,7 @@ internal void OnNewLicenseList() {
 									case EPurchaseResultDetail.BadActivationCode:
 									case EPurchaseResultDetail.CannotRedeemCodeFromClient:
 									case EPurchaseResultDetail.DuplicateActivationCode:
-									case EPurchaseResultDetail.NoDetail: // OK
+									case EPurchaseResultDetail.NoDetail:
 									case EPurchaseResultDetail.Timeout:
 										if ((result != EResult.Timeout) && (purchaseResultDetail != EPurchaseResultDetail.Timeout)) {
 											unusedKeys.Remove(key);
@@ -2750,21 +2750,20 @@ internal void OnNewLicenseList() {
 												continue;
 											}
 
-											if (redeemResponse.purchase_receipt_info == null) {
-												response.AppendLine(FormatBotResponse(Strings.FormatBotRedeem(key, $"{EResult.Timeout}/{EPurchaseResultDetail.NoDetail}"), innerBot.BotName));
-
-												continue;
-											}
-
 											triedBots.Add(innerBot);
 
-											EResult redeemResult = (EResult) redeemResponse.purchase_receipt_info.purchase_status;
-											EPurchaseResultDetail redeemPurchaseResult = (EPurchaseResultDetail) redeemResponse.purchase_result_details;
+											EResult redeemResult = EResult.BadResponse;
+											EPurchaseResultDetail redeemPurchaseResult = EPurchaseResultDetail.NoDetail;
+
+											if (redeemResponse.purchase_receipt_info != null) {
+												redeemResult = (EResult) redeemResponse.purchase_receipt_info.purchase_status;
+												redeemPurchaseResult = (EPurchaseResultDetail) redeemResponse.purchase_result_details;
+											}
 
 											switch (redeemPurchaseResult) {
 												case EPurchaseResultDetail.BadActivationCode:
 												case EPurchaseResultDetail.DuplicateActivationCode:
-												case EPurchaseResultDetail.NoDetail: // OK
+												case EPurchaseResultDetail.NoDetail:
 													// This key is already handled, as we either redeemed it or we're sure it's dupe/invalid
 													alreadyHandled = true;
 
@@ -2777,7 +2776,7 @@ internal void OnNewLicenseList() {
 													break;
 											}
 
-											Dictionary<uint, string>? redeemItems = redeemResponse.purchase_receipt_info.line_items.Count > 0 ? redeemResponse.purchase_receipt_info.line_items.ToDictionary(static lineItem => lineItem.packageid, static lineItem => lineItem.line_item_description) : null;
+											Dictionary<uint, string>? redeemItems = redeemResponse.purchase_receipt_info?.line_items.Count > 0 ? redeemResponse.purchase_receipt_info.line_items.ToDictionary(static lineItem => lineItem.packageid, static lineItem => lineItem.line_item_description) : null;
 
 											response.AppendLine(FormatBotResponse(redeemItems?.Count > 0 ? Strings.FormatBotRedeemWithItems(key, $"{redeemResult}/{redeemPurchaseResult}", string.Join(", ", redeemItems)) : Strings.FormatBotRedeem(key, $"{redeemResult}/{redeemPurchaseResult}"), innerBot.BotName));