Use ASF instead of Main for global logging routines, closes #280

Author: JustArchi

ArchiSteamFarm/Logging.cs

@@ -114,7 +114,7 @@ internal static void OnUserInputEnd() {
 			LogManager.ReconfigExistingLoggers();
 		}
 
-		internal static void LogGenericError(string message, string botName = "Main", [CallerMemberName] string previousMethodName = null) {
+		internal static void LogGenericError(string message, string botName = Program.ASF, [CallerMemberName] string previousMethodName = null) {
 			if (string.IsNullOrEmpty(message)) {
 				LogNullError(nameof(message), botName);
 				return;
@@ -123,7 +123,7 @@ internal static void LogGenericError(string message, string botName = "Main", [C
 			Logger.Error($"{botName}|{previousMethodName}() {message}");
 		}
 
-		internal static void LogGenericException(Exception exception, string botName = "Main", [CallerMemberName] string previousMethodName = null) {
+		internal static void LogGenericException(Exception exception, string botName = Program.ASF, [CallerMemberName] string previousMethodName = null) {
 			if (exception == null) {
 				LogNullError(nameof(exception), botName);
 				return;
@@ -132,7 +132,7 @@ internal static void LogGenericException(Exception exception, string botName = "
 			Logger.Error(exception, $"{botName}|{previousMethodName}()");
 		}
 
-		internal static void LogFatalException(Exception exception, string botName = "Main", [CallerMemberName] string previousMethodName = null) {
+		internal static void LogFatalException(Exception exception, string botName = Program.ASF, [CallerMemberName] string previousMethodName = null) {
 			if (exception == null) {
 				LogNullError(nameof(exception), botName);
 				return;
@@ -141,7 +141,7 @@ internal static void LogFatalException(Exception exception, string botName = "Ma
 			Logger.Fatal(exception, $"{botName}|{previousMethodName}()");
 		}
 
-		internal static void LogGenericWarning(string message, string botName = "Main", [CallerMemberName] string previousMethodName = null) {
+		internal static void LogGenericWarning(string message, string botName = Program.ASF, [CallerMemberName] string previousMethodName = null) {
 			if (string.IsNullOrEmpty(message)) {
 				LogNullError(nameof(message), botName);
 				return;
@@ -150,7 +150,7 @@ internal static void LogGenericWarning(string message, string botName = "Main",
 			Logger.Warn($"{botName}|{previousMethodName}() {message}");
 		}
 
-		internal static void LogGenericInfo(string message, string botName = "Main", [CallerMemberName] string previousMethodName = null) {
+		internal static void LogGenericInfo(string message, string botName = Program.ASF, [CallerMemberName] string previousMethodName = null) {
 			if (string.IsNullOrEmpty(message)) {
 				LogNullError(nameof(message), botName);
 				return;
@@ -160,7 +160,7 @@ internal static void LogGenericInfo(string message, string botName = "Main", [Ca
 		}
 
 		[SuppressMessage("ReSharper", "ExplicitCallerInfoArgument")]
-		internal static void LogNullError(string nullObjectName, string botName = "Main", [CallerMemberName] string previousMethodName = null) {
+		internal static void LogNullError(string nullObjectName, string botName = Program.ASF, [CallerMemberName] string previousMethodName = null) {
 			if (string.IsNullOrEmpty(nullObjectName)) {
 				return;
 			}
@@ -170,7 +170,7 @@ internal static void LogNullError(string nullObjectName, string botName = "Main"
 
 		[Conditional("DEBUG")]
 		[SuppressMessage("ReSharper", "UnusedMember.Global")]
-		internal static void LogGenericDebug(string message, string botName = "Main", [CallerMemberName] string previousMethodName = null) {
+		internal static void LogGenericDebug(string message, string botName = Program.ASF, [CallerMemberName] string previousMethodName = null) {
 			if (string.IsNullOrEmpty(message)) {
 				LogNullError(nameof(message), botName);
 				return;

ArchiSteamFarm/Program.cs

@@ -59,11 +59,11 @@ private enum EMode : byte {
 			Server // Normal + WCF server
 		}
 
+		internal const string ASF = "ASF";
 		internal const string ConfigDirectory = "config";
 		internal const string DebugDirectory = "debug";
 		internal const string LogFile = "log.txt";
 
-		private const string ASF = "ASF";
 		private const string GithubReleaseURL = "https://api.github.com/repos/" + SharedInfo.GithubRepo + "/releases"; // GitHub API is HTTPS only
 		private const string GlobalConfigFile = ASF + ".json";
 		private const string GlobalDatabaseFile = ASF + ".db";
@@ -274,7 +274,7 @@ internal static void Restart() {
 			Exit();
 		}
 
-		internal static string GetUserInput(EUserInputType userInputType, string botName = "Main", string extraInformation = null) {
+		internal static string GetUserInput(EUserInputType userInputType, string botName = ASF, string extraInformation = null) {
 			if (userInputType == EUserInputType.Unknown) {
 				return null;
 			}
@@ -386,7 +386,7 @@ private static void InitServices() {
 			WebBrowser.Init();
 			WCF.Init();
 
-			WebBrowser = new WebBrowser("Main");
+			WebBrowser = new WebBrowser(ASF);
 		}
 
 		private static void ParseArgs(IEnumerable<string> args) {
@@ -522,7 +522,6 @@ private static void Init(IEnumerable<string> args) {
 			foreach (string botName in Directory.EnumerateFiles(ConfigDirectory, "*.json").Select(Path.GetFileNameWithoutExtension)) {
 				switch (botName) {
 					case ASF:
-					case "Main":
 					case "example":
 					case "minimal":
 						continue;

ConfigGenerator/MainForm.cs

@@ -60,7 +60,6 @@ private void MainForm_Load(object sender, EventArgs args) {
 				string botName = Path.GetFileNameWithoutExtension(configFile);
 				switch (botName) {
 					case Program.ASF:
-					case "Main":
 					case "example":
 					case "minimal":
 						continue;
@@ -163,7 +162,6 @@ private void MainTab_Selected(object sender, TabControlEventArgs args) {
 
 				switch (input) {
 					case Program.ASF:
-					case "Main":
 					case "example":
 					case "minimal":
 						Logging.LogGenericErrorWithoutStacktrace("This name is reserved!");