Add MaxTradeHoldDuration

Author: JustArchi

ArchiSteamFarm/GlobalConfig.cs

@@ -89,6 +89,9 @@ internal enum EUpdateChannel : byte {
 		[JsonProperty(Required = Required.DisallowNull)]
 		internal byte GiftsLimiterDelay { get; private set; } = 1;
 
+		[JsonProperty(Required = Required.DisallowNull)]
+		internal byte MaxTradeHoldDuration { get; private set; } = 15;
+
 		[JsonProperty(Required = Required.DisallowNull)]
 		internal bool ForceHttp { get; private set; } = false;
 

ArchiSteamFarm/Trading.cs

@@ -185,14 +185,17 @@ private async Task<ParseTradeResult> ShouldAcceptTrade(Steam.TradeOffer tradeOff
 
 			// At this point we're sure that STM trade is valid
 
-			// If we're dealing with special cards with short lifespan, accept the trade only if user doesn't have trade holds
-			if (tradeOffer.ItemsToGive.Any(item => GlobalConfig.GlobalBlacklist.Contains(item.RealAppID))) {
-				byte? holdDuration = await Bot.ArchiWebHandler.GetTradeHoldDuration(tradeOffer.TradeOfferID).ConfigureAwait(false);
-				if (!holdDuration.HasValue) {
-					return ParseTradeResult.RejectedTemporarily;
-				}
+			// Fetch trade hold duration
+			byte? holdDuration = await Bot.ArchiWebHandler.GetTradeHoldDuration(tradeOffer.TradeOfferID).ConfigureAwait(false);
+			if (!holdDuration.HasValue) {
+				// If we can't get trade hold duration, reject trade temporarily
+				return ParseTradeResult.RejectedTemporarily;
+			}
 
-				if (holdDuration.Value > 0) {
+			// If user has a trade hold, we add extra logic
+			if (holdDuration.Value > 0) {
+				// If trade hold duration exceeds our max, or user asks for cards with short lifespan, reject the trade
+				if ((holdDuration.Value > Program.GlobalConfig.MaxTradeHoldDuration) || tradeOffer.ItemsToGive.Any(item => GlobalConfig.GlobalBlacklist.Contains(item.RealAppID))) {
 					return ParseTradeResult.RejectedPermanently;
 				}
 			}

ArchiSteamFarm/config/ASF.json

@@ -12,6 +12,7 @@
   "LoginLimiterDelay": 10,
   "InventoryLimiterDelay": 3,
   "GiftsLimiterDelay": 1,
+  "MaxTradeHoldDuration": 15,
   "ForceHttp": false,
   "HttpTimeout": 60,
   "WCFHostname": "localhost",

ConfigGenerator/GlobalConfig.cs

@@ -89,6 +89,9 @@ internal enum EUpdateChannel : byte {
 		[JsonProperty(Required = Required.DisallowNull)]
 		public byte GiftsLimiterDelay { get; set; } = 1;
 
+		[JsonProperty(Required = Required.DisallowNull)]
+		public byte MaxTradeHoldDuration { get; set; } = 15;
+
 		[JsonProperty(Required = Required.DisallowNull)]
 		public bool ForceHttp { get; set; } = false;