Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in ProgressIndicator plugin is causing crash in iOS #34

Closed
Justin-Credible opened this issue Jul 10, 2015 · 1 comment · Fixed by #51
Closed

Bug in ProgressIndicator plugin is causing crash in iOS #34

Justin-Credible opened this issue Jul 10, 2015 · 1 comment · Fixed by #51
Labels

Comments

@Justin-Credible
Copy link
Owner

The ProgressIndicator native code plugin (org.pbernasconi.progressindicator) is causing EXC_BAD_ACCESS crashes in iOS. This seems to occur sometimes when calling hide() after an indicator has already been hidden. This happens in the JavaScript exception handlers in Application.ts.

There are a couple of options here:

  1. Look for a replacement progress indicator plugin
  2. Don't call hide() in the script exception handlers
  3. Fork and attempt to fix the current plugin
  4. Submit issue to the original plugin maintainer

Option 1 is attractive because the current plugin does not support Android, so finding an alternative plugin that has Android support would allow me to ditch the MockApi implementation for Android. If no subtable alternative could be found, perhaps I could just use the mock implementation which utilizes Ionic.

I would like to avoid option 2 because if an exception occurs during an HTTP request the progress indicator may never be hidden, leaving the user stuck.

I'll try 4 for now; opened pbernasconi/cordova-progressIndicator#20.

@Justin-Credible
Copy link
Owner Author

I have submitted a fix and pull request for this bug in the plugin's github project. Waiting for this to be merged...

pbernasconi/cordova-progressIndicator#21

Justin-Credible added a commit that referenced this issue Aug 3, 2015
• Upgraded to the new jsproj format and project file layout; resolves #48
• Switched plug-in to use npm identifiers rather than the old Cordova plugin IDs; resolves #46
• Upgraded to Cordova 5.1.1; resolves #45
• Added white list plug-in and added a default Content-Security-Policy; resolves #47
• Upgraded plug-in versions
• Switched progress indicator from org.pbernasconi.progressindicator to my custom fork net.justin-credible.cordova-progress-indicator; resolves #34
• Upgraded plug-inversions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant