Skip to content

Commit 3234243

Browse files
authored
FPv2: add comment about nuance of fuzzy fingerprinting (commaai#28465)
add comment describing this nuance of fuzzy fingerprint function
1 parent 5736cb8 commit 3234243

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

selfdrive/car/fw_versions.py

+2
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,8 @@ def match_fw_to_car_fuzzy(fw_versions_dict, log=True, exclude=None):
9191
elif candidate != candidates[0]:
9292
return set()
9393

94+
# Note that it is possible to match to a candidate without all its ECUs being present
95+
# if there are enough matches. FIXME: parameterize this or require all ECUs to exist like exact matching
9496
if len(matched_ecus) >= 2:
9597
if log:
9698
cloudlog.error(f"Fingerprinted {candidate} using fuzzy match. {len(matched_ecus)} matching ECUs")

0 commit comments

Comments
 (0)