test_*.py files are no longer executable (commaai#32610)

adeebshihadeh · web-flow · commit c59887c8109d · 2024-06-03T15:48:56.000-07:00
* test_*.py files are no longer executable

* cleanup empty lines

* update precommit

* fixme

* enable

* build
diff --git a/.github/workflows/selfdrive_tests.yaml b/.github/workflows/selfdrive_tests.yaml
@@ -116,6 +116,8 @@ jobs:
         submodules: true
     - uses: ./.github/workflows/setup-pre-commit
     - uses: ./.github/workflows/setup-with-retry
+    - name: Build openpilot
+      run: ${{ env.RUN }} "scons -j$(nproc)"
     - name: pre-commit
       timeout-minutes: 4
       run: ${{ env.RUN }} "unset PYTHONWARNINGS && pre-commit run --all && chmod -R 777 /tmp/pre-commit"
@@ -143,7 +145,7 @@ jobs:
                         $PYTEST --timeout 60 -m 'not slow' && \
                         ./selfdrive/ui/tests/create_test_translations.sh && \
                         QT_QPA_PLATFORM=offscreen ./selfdrive/ui/tests/test_translations && \
-                        ./selfdrive/ui/tests/test_translations.py"
+                        pytest ./selfdrive/ui/tests/test_translations.py"
     - name: "Upload coverage to Codecov"
       uses: codecov/codecov-action@v4
       with:
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -86,8 +86,8 @@ repos:
     hooks:
     -   id: test_translations
         name: test translations
-        entry: selfdrive/ui/tests/test_translations.py
-        language: script
+        entry: pytest selfdrive/ui/tests/test_translations.py
+        language: system
         pass_filenames: false
         files: '^selfdrive/ui/translations/'
 -   repo: https://github.com/python-poetry/poetry
diff --git a/common/transformations/tests/test_coordinates.py b/common/transformations/tests/test_coordinates.py
@@ -1,5 +1,3 @@
-#!/usr/bin/env python3
-
 import numpy as np
 
 import openpilot.common.transformations.coordinates as coord
diff --git a/common/transformations/tests/test_orientation.py b/common/transformations/tests/test_orientation.py
@@ -1,5 +1,3 @@
-#!/usr/bin/env python3
-
 import numpy as np
 
 from openpilot.common.transformations.orientation import euler2quat, quat2euler, euler2rot, rot2euler, \
diff --git a/selfdrive/boardd/tests/test_boardd_loopback.py b/selfdrive/boardd/tests/test_boardd_loopback.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import os
 import copy
 import random
diff --git a/selfdrive/boardd/tests/test_boardd_spi.py b/selfdrive/boardd/tests/test_boardd_spi.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import os
 import time
 import numpy as np
diff --git a/selfdrive/boardd/tests/test_pandad.py b/selfdrive/boardd/tests/test_pandad.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import os
 import pytest
 import time
diff --git a/selfdrive/car/ford/tests/test_ford.py b/selfdrive/car/ford/tests/test_ford.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import random
 from collections.abc import Iterable
 
diff --git a/selfdrive/car/gm/tests/test_gm.py b/selfdrive/car/gm/tests/test_gm.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 from parameterized import parameterized
 
 from openpilot.selfdrive.car.gm.fingerprints import FINGERPRINTS
diff --git a/selfdrive/car/honda/tests/test_honda.py b/selfdrive/car/honda/tests/test_honda.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import re
 
 from openpilot.selfdrive.car.honda.fingerprints import FW_VERSIONS
diff --git a/selfdrive/car/hyundai/tests/test_hyundai.py b/selfdrive/car/hyundai/tests/test_hyundai.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 from hypothesis import settings, given, strategies as st
 
 import pytest
diff --git a/selfdrive/car/tests/test_can_fingerprint.py b/selfdrive/car/tests/test_can_fingerprint.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 from parameterized import parameterized
 
 from cereal import log, messaging
diff --git a/selfdrive/car/tests/test_car_interfaces.py b/selfdrive/car/tests/test_car_interfaces.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import os
 import math
 import hypothesis.strategies as st
diff --git a/selfdrive/car/tests/test_docs.py b/selfdrive/car/tests/test_docs.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 from collections import defaultdict
 import os
 import pytest
diff --git a/selfdrive/car/tests/test_fingerprints.py b/selfdrive/car/tests/test_fingerprints.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import os
 import sys
 
diff --git a/selfdrive/car/tests/test_fw_fingerprint.py b/selfdrive/car/tests/test_fw_fingerprint.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import pytest
 import random
 import time
diff --git a/selfdrive/car/tests/test_lateral_limits.py b/selfdrive/car/tests/test_lateral_limits.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 from collections import defaultdict
 import importlib
 from parameterized import parameterized_class
diff --git a/selfdrive/car/tests/test_models.py b/selfdrive/car/tests/test_models.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import capnp
 import os
 import importlib
diff --git a/selfdrive/car/tests/test_platform_configs.py b/selfdrive/car/tests/test_platform_configs.py
@@ -1,5 +1,3 @@
-#!/usr/bin/env python3
-
 from openpilot.selfdrive.car.values import PLATFORMS
 
 
diff --git a/selfdrive/car/toyota/tests/test_toyota.py b/selfdrive/car/toyota/tests/test_toyota.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 from hypothesis import given, settings, strategies as st
 
 from cereal import car
diff --git a/selfdrive/car/volkswagen/tests/test_volkswagen.py b/selfdrive/car/volkswagen/tests/test_volkswagen.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import random
 import re
 
diff --git a/selfdrive/controls/lib/tests/test_alertmanager.py b/selfdrive/controls/lib/tests/test_alertmanager.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import random
 
 from openpilot.selfdrive.controls.lib.events import Alert, EVENTS
diff --git a/selfdrive/controls/lib/tests/test_latcontrol.py b/selfdrive/controls/lib/tests/test_latcontrol.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 from parameterized import parameterized
 
 from cereal import car, log
diff --git a/selfdrive/controls/lib/tests/test_vehicle_model.py b/selfdrive/controls/lib/tests/test_vehicle_model.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import pytest
 import math
 
diff --git a/selfdrive/controls/tests/test_alerts.py b/selfdrive/controls/tests/test_alerts.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import copy
 import json
 import os
diff --git a/selfdrive/controls/tests/test_cruise_speed.py b/selfdrive/controls/tests/test_cruise_speed.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import pytest
 import itertools
 import numpy as np
diff --git a/selfdrive/controls/tests/test_following_distance.py b/selfdrive/controls/tests/test_following_distance.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import pytest
 import itertools
 from parameterized import parameterized_class
diff --git a/selfdrive/controls/tests/test_leads.py b/selfdrive/controls/tests/test_leads.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import cereal.messaging as messaging
 
 from openpilot.selfdrive.test.process_replay import replay_process_with_name
diff --git a/selfdrive/controls/tests/test_state_machine.py b/selfdrive/controls/tests/test_state_machine.py
@@ -1,5 +1,3 @@
-#!/usr/bin/env python3
-
 from cereal import car, log
 from openpilot.common.realtime import DT_CTRL
 from openpilot.selfdrive.car.car_helpers import interfaces
diff --git a/selfdrive/debug/test_fw_query_on_routes.py b/selfdrive/debug/test_fw_query_on_routes.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 # type: ignore
 
 from collections import defaultdict
diff --git a/selfdrive/locationd/test/test_calibrationd.py b/selfdrive/locationd/test/test_calibrationd.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import random
 
 import numpy as np
diff --git a/selfdrive/locationd/test/test_locationd.py b/selfdrive/locationd/test/test_locationd.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import pytest
 import json
 import random
diff --git a/selfdrive/locationd/test/test_locationd_scenarios.py b/selfdrive/locationd/test/test_locationd_scenarios.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import pytest
 import numpy as np
 from collections import defaultdict
diff --git a/selfdrive/modeld/tests/test_modeld.py b/selfdrive/modeld/tests/test_modeld.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import numpy as np
 import random
 
diff --git a/selfdrive/monitoring/test_monitoring.py b/selfdrive/monitoring/test_monitoring.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import numpy as np
 
 from cereal import car, log
diff --git a/selfdrive/navd/tests/test_map_renderer.py b/selfdrive/navd/tests/test_map_renderer.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import time
 import numpy as np
 import os
diff --git a/selfdrive/navd/tests/test_navd.py b/selfdrive/navd/tests/test_navd.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import json
 import random
 import numpy as np
diff --git a/selfdrive/test/longitudinal_maneuvers/test_longitudinal.py b/selfdrive/test/longitudinal_maneuvers/test_longitudinal.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import itertools
 from parameterized import parameterized_class
 
diff --git a/selfdrive/test/process_replay/test_fuzzy.py b/selfdrive/test/process_replay/test_fuzzy.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import copy
 from hypothesis import given, HealthCheck, Phase, settings
 import hypothesis.strategies as st
diff --git a/selfdrive/test/process_replay/test_imgproc.py b/selfdrive/test/process_replay/test_imgproc.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import os
 import numpy as np
 import hashlib
diff --git a/selfdrive/test/process_replay/test_processes.py b/selfdrive/test/process_replay/test_processes.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import argparse
 import concurrent.futures
 import os
diff --git a/selfdrive/test/process_replay/test_regen.py b/selfdrive/test/process_replay/test_regen.py
@@ -1,5 +1,3 @@
-#!/usr/bin/env python3
-
 from parameterized import parameterized
 
 from openpilot.selfdrive.test.process_replay.regen import regen_segment, DummyFrameReader
diff --git a/selfdrive/test/test_onroad.py b/selfdrive/test/test_onroad.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import bz2
 import math
 import json
diff --git a/selfdrive/test/test_time_to_onroad.py b/selfdrive/test/test_time_to_onroad.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import os
 import pytest
 import time
diff --git a/selfdrive/test/test_updated.py b/selfdrive/test/test_updated.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import datetime
 import os
 import pytest
diff --git a/selfdrive/ui/tests/test_soundd.py b/selfdrive/ui/tests/test_soundd.py
@@ -1,5 +1,3 @@
-#!/usr/bin/env python3
-
 from cereal import car
 from cereal import messaging
 from cereal.messaging import SubMaster, PubMaster
diff --git a/selfdrive/ui/tests/test_translations.py b/selfdrive/ui/tests/test_translations.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import pytest
 import json
 import os
diff --git a/system/athena/tests/test_athenad.py b/system/athena/tests/test_athenad.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import pytest
 from functools import wraps
 import json
diff --git a/system/athena/tests/test_athenad_ping.py b/system/athena/tests/test_athenad_ping.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import pytest
 import subprocess
 import threading
diff --git a/system/athena/tests/test_registration.py b/system/athena/tests/test_registration.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import json
 from Crypto.PublicKey import RSA
 from pathlib import Path
diff --git a/system/camerad/test/test_camerad.py b/system/camerad/test/test_camerad.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import pytest
 import time
 import numpy as np
diff --git a/system/camerad/test/test_exposure.py b/system/camerad/test/test_exposure.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import time
 import numpy as np
 
diff --git a/system/hardware/tici/tests/test_agnos_updater.py b/system/hardware/tici/tests/test_agnos_updater.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import json
 import os
 import requests
diff --git a/system/hardware/tici/tests/test_amplifier.py b/system/hardware/tici/tests/test_amplifier.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import pytest
 import time
 import random
diff --git a/system/hardware/tici/tests/test_hardware.py b/system/hardware/tici/tests/test_hardware.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import pytest
 import time
 import numpy as np
diff --git a/system/hardware/tici/tests/test_power_draw.py b/system/hardware/tici/tests/test_power_draw.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 from collections import defaultdict, deque
 import pytest
 import time
diff --git a/system/loggerd/tests/test_deleter.py b/system/loggerd/tests/test_deleter.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import time
 import threading
 from collections import namedtuple
diff --git a/system/loggerd/tests/test_encoder.py b/system/loggerd/tests/test_encoder.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import math
 import os
 import pytest
diff --git a/system/loggerd/tests/test_loggerd.py b/system/loggerd/tests/test_loggerd.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import numpy as np
 import os
 import re
diff --git a/system/loggerd/tests/test_uploader.py b/system/loggerd/tests/test_uploader.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import os
 import time
 import threading
diff --git a/system/manager/test/test_manager.py b/system/manager/test/test_manager.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import os
 import pytest
 import signal
diff --git a/system/qcomgpsd/tests/test_qcomgpsd.py b/system/qcomgpsd/tests/test_qcomgpsd.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import os
 import pytest
 import json
diff --git a/system/sensord/tests/test_sensord.py b/system/sensord/tests/test_sensord.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import os
 import pytest
 import time
diff --git a/system/tests/test_logmessaged.py b/system/tests/test_logmessaged.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import glob
 import os
 import time
diff --git a/system/thermald/tests/test_fan_controller.py b/system/thermald/tests/test_fan_controller.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import pytest
 
 from openpilot.system.thermald.fan_controller import TiciFanController
diff --git a/system/thermald/tests/test_power_monitoring.py b/system/thermald/tests/test_power_monitoring.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import pytest
 
 from openpilot.common.params import Params
diff --git a/system/ubloxd/tests/test_pigeond.py b/system/ubloxd/tests/test_pigeond.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import pytest
 import time
 
diff --git a/system/updated/casync/tests/test_casync.py b/system/updated/casync/tests/test_casync.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import pytest
 import os
 import pathlib
diff --git a/system/webrtc/tests/test_stream_session.py b/system/webrtc/tests/test_stream_session.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import asyncio
 import json
 # for aiortc and its dependencies
diff --git a/system/webrtc/tests/test_webrtcd.py b/system/webrtc/tests/test_webrtcd.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python
 import pytest
 import asyncio
 import json
diff --git a/third_party/acados/acados_template/gnsf/__init__.py b/third_party/acados/acados_template/gnsf/__init__.py
@@ -1 +0,0 @@
-
diff --git a/tools/car_porting/test_car_model.py b/tools/car_porting/test_car_model.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import argparse
 import sys
 import unittest # noqa: TID251
diff --git a/tools/lib/tests/test_caching.py b/tools/lib/tests/test_caching.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import http.server
 import os
 import shutil
diff --git a/tools/lib/tests/test_logreader.py b/tools/lib/tests/test_logreader.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 import capnp
 import contextlib
 import io
diff --git a/tools/lib/tests/test_readers.py b/tools/lib/tests/test_readers.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python
 import pytest
 import requests
 import tempfile
diff --git a/tools/lib/tests/test_route_library.py b/tools/lib/tests/test_route_library.py
diff --git a/tools/plotjuggler/test_plotjuggler.py b/tools/plotjuggler/test_plotjuggler.py
diff --git a/tools/sim/tests/test_metadrive_bridge.py b/tools/sim/tests/test_metadrive_bridge.py
