Fix clazy warning "Missing reference on non-trivial type (class QTextCharFormat)"

dfaure-kdab · dfaure-kdab · commit 1237ca2480dd · 2025-03-17T22:24:13.000+01:00
diff --git a/src/KDReports/KDReportsTableElement.cpp b/src/KDReports/KDReportsTableElement.cpp
@@ -27,7 +27,7 @@ using CellContentMap = QMap<QPair<int /*row*/, int /*column*/>, Cell>;
 class KDReports::TableElementPrivate
 {
 public:
-    void createCell(QTextTable *textTable, ReportBuilder &builder, int row, int column, const Cell &cell, QTextCharFormat charFormat) const;
+    void createCell(QTextTable *textTable, ReportBuilder &builder, int row, int column, const Cell &cell, const QTextCharFormat &charFormat) const;
 
     KDReports::CellContentMap m_cellContentMap;
     int m_rowCount = 0;
@@ -107,7 +107,7 @@ KDReports::Cell &KDReports::TableElement::cell(int row, int column)
     return d->m_cellContentMap[coord]; // find or create
 }
 
-void KDReports::TableElementPrivate::createCell(QTextTable *textTable, ReportBuilder &builder, int row, int column, const Cell &cell, QTextCharFormat charFormat) const
+void KDReports::TableElementPrivate::createCell(QTextTable *textTable, ReportBuilder &builder, int row, int column, const Cell &cell, const QTextCharFormat &charFormat) const
 {
     if (cell.columnSpan() > 1 || cell.rowSpan() > 1)
         textTable->mergeCells(row, column, cell.rowSpan(), cell.columnSpan());

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ using CellContentMap = QMap<QPair<int /row/, int /column/>, Cell>;`
`27`	`27`	`class KDReports::TableElementPrivate`
`28`	`28`	`{`
`29`	`29`	`public:`
`30`		`- void createCell(QTextTable *textTable, ReportBuilder &builder, int row, int column, const Cell &cell, QTextCharFormat charFormat) const;`
	`30`	`+ void createCell(QTextTable *textTable, ReportBuilder &builder, int row, int column, const Cell &cell, const QTextCharFormat &charFormat) const;`
`31`	`31`
`32`	`32`	`KDReports::CellContentMap m_cellContentMap;`
`33`	`33`	`int m_rowCount = 0;`
`@@ -107,7 +107,7 @@ KDReports::Cell &KDReports::TableElement::cell(int row, int column)`
`107`	`107`	`return d->m_cellContentMap[coord]; // find or create`
`108`	`108`	`}`
`109`	`109`
`110`		`-void KDReports::TableElementPrivate::createCell(QTextTable *textTable, ReportBuilder &builder, int row, int column, const Cell &cell, QTextCharFormat charFormat) const`
	`110`	`+void KDReports::TableElementPrivate::createCell(QTextTable *textTable, ReportBuilder &builder, int row, int column, const Cell &cell, const QTextCharFormat &charFormat) const`
`111`	`111`	`{`
`112`	`112`	`if (cell.columnSpan() > 1 \|\| cell.rowSpan() > 1)`
`113`	`113`	`textTable->mergeCells(row, column, cell.rowSpan(), cell.columnSpan());`