Add a flag to strip a file in-place

[marcospb19]

Thanks for the tool, I usually use it to fix files.

Similar to sed, I'd suggest to keep it reading from stdin as default, but add a -i/--in-place flag that receives a input file to change.

An alternative would be to accept files by default, but if you provide the --stdin flag, read from stdin and output to stdout.

---

Let me know if you like the idea, I'm willing to help if you need it.

[KSXGitHub]

The alternative is a breaking change, so I won't allow that. I'll be waiting for you to make a pull request regarding the in-place option (because I'm busy with another project right now). Make sure to set conflicts_with between the --in-place flag and the text argument.

[marcospb19]

Sorry, I hit a barrier and gave up.

Had to do complicated configurations with structopt, but I couldn't, and upgrading to clap broke some dependencies.

I just did a fork to fulfill my own needs.

use std::path::PathBuf;

#[derive(structopt::StructOpt)]
#[structopt(name = "strip-ansi")]
pub struct Args {
    /// Files to strip, read from `stdin` if not specified.
    pub files: Vec<PathBuf>,
}

To me it makes more sense to have it like this, avoiding dealing with a complicated CLI interface, it's redundant to have text as input both from STDIN and CLI.

I wouldn't advise having a flag that conflicts with your main argument in this case, you can just mimic what UNIX coreutils like cat, head, tail, uniq and sort do.

So feel free to close the issue if you don't need this.

[KSXGitHub]

Upon seeing your feedback, I reexamine the code and see the following things:

• conflicts_with doesn't work with positional arguments.
• For --in-place to work, the user has to provide file names. But the positional argument is already named TEXT, so it wouldn't make sense for user to provide file names via this argument. However, the --in-place flag can be set to be an option (i.e. Option<PathBuf> or Vec<PathBuf>), which would make sense.

upgrading to clap broke some dependencies.

I guess it doesn't work with structopt-utilities? There is clap-utilities for clap v4.

To me it makes more sense to have it like this, avoiding dealing with a complicated CLI interface, it's redundant to have text as input both from STDIN and CLI.

It makes sense now that you say it. But initially, this was a port of strip-ansi-cli from NPM.

So feel free to close the issue if you don't need this.

I have no problem waiting for someone else to pick it up.