Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very large diff returns an error #22

Open
elliots opened this issue Dec 11, 2022 · 2 comments
Open

Very large diff returns an error #22

elliots opened this issue Dec 11, 2022 · 2 comments

Comments

@elliots
Copy link

elliots commented Dec 11, 2022

I got an "Error: OpenAI query too big" testing it with a large xml file with a bunch of changes.

Maybe limit the diff to a reasonable size and include a note that it was trimmed?

(Very cool by the way)

@elliots
Copy link
Author

elliots commented Dec 11, 2022

Ah, i see that it is already supposed to throw an error if its too big...

https://github.com/KanHarI/gpt-commit-summarizer/blob/master/src/summarizePr.ts#L46-L48

@elliots elliots changed the title Very change diff returns an error Very large diff returns an error Dec 11, 2022
@jjl-genemod
Copy link

Yeah it would be nice if there was more fine grained control over when it comments on large prs.

PS: Thank you to the creator of this. It's very very cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants