Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to scroll to the next / previous chapter for short webtoons #1590

Open
TheIceCreamTroll opened this issue Oct 18, 2022 · 4 comments · May be fixed by #3006
Open

Unable to scroll to the next / previous chapter for short webtoons #1590

TheIceCreamTroll opened this issue Oct 18, 2022 · 4 comments · May be fixed by #3006
Labels
bug Something isn't working edge-case This is an edge case and may or maynot be fixed/implemented help wanted Extra attention is needed UI Primarily UI impacting

Comments

@TheIceCreamTroll
Copy link
Contributor

Describe the bug
If a webtoon isn't long enough to require a scrollbar be generated, you will not be able to turn to scrollwheel to go to the next / previous chapters

To Reproduce
Steps to reproduce the behavior:

  1. Open a very short webtoon and make sure there isn't a scrollbar
  2. Switch the reading mode to continuous scrolling
  3. Scroll in either direction
  4. The "Scroll to next / previous chapter" message should not appear

Expected behavior
You should always be able to scroll to go to the next / previous page, no matter the chapter length.

Desktop (please complete the following information):

  • OS: Docker
  • Browser Firefox
  • Version 0.5.6.29

Additional context
Here's a test file. Copy the images to increase the page length
Kavita Testing Ch. 1.zip
@TheIceCreamTroll TheIceCreamTroll added bug Something isn't working help wanted Extra attention is needed labels Oct 18, 2022
@majora2007 majora2007 added the UI Primarily UI impacting label Oct 18, 2022
@majora2007
Copy link
Member

This issue is fixed in latest code, let me know if not.

@TheIceCreamTroll
Copy link
Contributor Author

Still seeing this issue with the included test file on 0.7.1.12

@majora2007 majora2007 added the edge-case This is an edge case and may or maynot be fixed/implemented label Mar 19, 2023
@majora2007
Copy link
Member

I was able to reproduce this, but I'm not sure if the level of effort to support it is worth given the edge case itself, esp when users can use the menu as a workaround. I'll leave this open and move to backlog.

@duplaja
Copy link

duplaja commented Jul 5, 2023

Just leaving a comment that this happens when the final image in a chapter is short as well.

core.mjs:10132 ERROR TypeError: Cannot read properties of undefined (reading 'getPageAmount')
at s.nextPage (manga-reader.component.ts:1134:53)
at s.handleKeyPress (manga-reader.component.ts:648:16)
at manga-reader.component.ts:104:14
at mm (core.mjs:15652:16)
at c (core.mjs:15685:22)
at platform-browser.mjs:666:17
at v.invokeTask (zone.js:402:31)
at Object.onInvokeTask (core.mjs:26095:33)
at v.invokeTask (zone.js:401:60)
at L.runTask (zone.js:171:47)

If you use the arrow key to force it to advance, rather than the menu, then it goes to a black screen with a loading symbol, and you must back-out and re-enter the story for it to work (Chrome browser, laptop)

@Zackareee Zackareee linked a pull request Jun 18, 2024 that will close this issue
Open
@majora2007 majora2007 moved this to To do in Backlog Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working edge-case This is an edge case and may or maynot be fixed/implemented help wanted Extra attention is needed UI Primarily UI impacting
Projects
Backlog
Status: To do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix: Scrolling functionality on short webtoons Zackareee/Kavita
3 participants
@majora2007 @duplaja @TheIceCreamTroll