[Magiclysm] Collapse Boreal Mage's Cold Aura into a single trait (CleverRaven#83362)

* Initial commit

* Change cost to 2

* Cold damage is randomized

* Add slow chill effect

* COLDPROOF and COLD_IMMUNE targets cannot be chilled

Author: Standing-Storm

data/mods/Magiclysm/Spells/infrastructure.json

@@ -20,13 +20,16 @@
       "//~": "NO_I18N"
     },
     "valid_targets": [ "hostile" ],
-    "flags": [ "SILENT", "NO_PROJECTILE", "NO_EXPLOSION_SFX", "SPLIT_DAMAGE" ],
+    "flags": [ "SILENT", "NO_PROJECTILE", "NO_EXPLOSION_SFX", "SPLIT_DAMAGE", "RANDOM_DAMAGE", "RANDOM_DURATION" ],
     "effect": "attack",
+    "effect_str": "boreal_mage_slow_chilled",
     "shape": "blast",
-    "min_damage": 5,
-    "max_damage": 5,
+    "min_damage": 3,
+    "max_damage": 10,
     "min_aoe": 3,
     "max_aoe": 3,
+    "min_duration": 500,
+    "max_duration": 600,
     "damage_type": "cold"
   },
   {

data/mods/Magiclysm/effect_on_conditions/attunement_choices.json

@@ -747,7 +747,11 @@
         { "test_eoc": "EOC_CONDITION_ATTUNEMENT_CHECK_PROFICIENCY_MASTERY" }
       ]
     },
-    "effect": [ { "u_add_trait": "BOREAL_MAGE" }, { "run_eocs": "EOC_ATTUNEMENT_SUCCESS_MESSAGE" } ]
+    "effect": [
+      { "u_add_trait": "BOREAL_MAGE" },
+      { "u_add_trait": "BOREAL_MAGE_COLD_AURA" },
+      { "run_eocs": "EOC_ATTUNEMENT_SUCCESS_MESSAGE" }
+    ]
   },
   {
     "type": "effect_on_condition",

data/mods/Magiclysm/effect_on_conditions/attunements.json

@@ -24,22 +24,6 @@
       }
     ]
   },
-  {
-    "type": "effect_on_condition",
-    "id": "EOC_GIVE_COLD_AURA_OFF",
-    "recurrence": [ "60 s", "60 s" ],
-    "condition": {
-      "and": [
-        { "u_has_trait": "BOREAL_MAGE" },
-        { "not": { "compare_string": [ "yes", { "u_val": "attunement_attunement_u_got_boreal_mage_attunement" } ] } }
-      ]
-    },
-    "deactivate_condition": { "not": { "u_has_trait": "BOREAL_MAGE" } },
-    "effect": [
-      { "u_add_trait": "COLD_AURA_OFF" },
-      { "u_add_var": "attunement_attunement_u_got_boreal_mage_attunement", "value": "yes" }
-    ]
-  },
   {
     "type": "effect_on_condition",
     "id": "EOC_DUST_REBORN_INITIAL",

data/mods/Magiclysm/effects/effects.json

@@ -775,6 +775,18 @@
     "base_mods": { "speed_mod": [ -30 ] },
     "scaling_mods": { "speed_mod": [ -30 ] }
   },
+  {
+    "type": "effect_type",
+    "id": "boreal_mage_slow_chilled",
+    "name": [ "Chilled" ],
+    "desc": [ "A frozen aura has chilled you to the bone." ],
+    "apply_message": "You feel yourself getting slower, as ice seems to run through your veins.",
+    "remove_message": "The bone-deep chill fades away.",
+    "rating": "bad",
+    "show_in_info": true,
+    "immune_flags": [ "COLD_IMMUNE", "COLDPROOF" ],
+    "base_mods": { "speed_mod": [ -20 ] }
+  },
   {
     "type": "effect_type",
     "id": "overclocker_drive_effect",

data/mods/Magiclysm/migration_and_obsoletion/eocs.json

@@ -162,5 +162,11 @@
       { "npc_remove_item_with": "warg_food" },
       { "u_spawn_item": "meat", "suppress_message": true }
     ]
+  },
+  {
+    "type": "effect_on_condition",
+    "id": "EOC_GIVE_COLD_AURA_OFF",
+    "//": "Remove in 0.J",
+    "effect": [  ]
   }
 ]

data/mods/Magiclysm/migration_and_obsoletion/mutations.json

@@ -30,5 +30,17 @@
     "type": "TRAIT_MIGRATION",
     "id": "BIOMANCER_EAT_TONS_OF_FOOD_05",
     "remove": true
+  },
+  {
+    "type": "TRAIT_MIGRATION",
+    "//": "remove after 0.J",
+    "id": "COLD_AURA_OFF",
+    "trait": "BOREAL_MAGE_COLD_AURA"
+  },
+  {
+    "type": "TRAIT_MIGRATION",
+    "//": "remove after 0.J",
+    "id": "COLD_AURA_ON",
+    "trait": "BOREAL_MAGE_COLD_AURA"
   }
 ]

data/mods/Magiclysm/mutations/spell_triggering_mutations.json

@@ -1,33 +1,26 @@
 [
   {
     "type": "mutation",
-    "id": "COLD_AURA_OFF",
+    "id": "BOREAL_MAGE_COLD_AURA",
     "starting_trait": false,
     "purifiable": false,
     "valid": false,
     "name": { "str": "Cold Aura" },
     "points": 0,
     "active": true,
-    "description": "Your presence is so dangerous you can freeze everything around yourself.  You are currently suppressing this power.",
-    "transform": { "target": "COLD_AURA_ON", "msg_transform": "Everything around you is covered in frost!", "active": true, "moves": 10 }
-  },
-  {
-    "type": "mutation",
-    "id": "COLD_AURA_ON",
-    "starting_trait": false,
-    "purifiable": false,
-    "valid": false,
-    "active": true,
-    "name": { "str": "Cold Aura (on)" },
-    "points": -1,
+    "activated_is_setup": true,
+    "cost": 2,
+    "mana": true,
+    "time": 5,
     "description": "Your presence is so dangerous you can freeze everything around yourself.",
+    "activation_msg": "Everything around you is covered in frost!",
     "enchantments": [
       {
+        "condition": "ACTIVE",
         "intermittent_activation": { "effects": [ { "frequency": "5 seconds", "spell_effects": [ { "id": "boreal_mage_cold_damage" } ] } ] }
       }
     ],
-    "transform": { "target": "COLD_AURA_OFF", "msg_transform": "You suppress your frozen powers.", "active": false, "moves": 10 },
-    "flags": [ "NO_BODY_HEAT" ]
+    "active_flags": [ "NO_BODY_HEAT" ]
   },
   {
     "type": "mutation",

doc/JSON/EFFECTS_JSON.md

@@ -273,7 +273,7 @@ matching trait or effect then they are "resisting" the effect, which changes its
 ```jsonc
 "immune_flags": [ "INFECTION_IMMUNE", "YOUR_FLAG" ]
 ```
-Having any of the defined character flags (See JSON_FLAGS.md#Character flags) will make you immune to the effect. Note that these are completely JSON-driven, so you can add a custom flag for your effect without C++ changes.
+Having any of the defined character flags (See JSON_FLAGS.md#Character flags) or monster flags will make the target immune to the effect. Note that these are completely JSON-driven, so you can add a custom flag for your effect without C++ changes.
 
 ### Bodypart Immunity Flags