fix: graph state and config cache (#21)

Author: ijusttookadnatest

packages/mcp/mcps.json

@@ -439,7 +439,7 @@
       "args": ["-y", "@kasarlabs/ask-starknet-help-mcp@latest"],
       "transport": "stdio"
     },
-    "description": "Help and documentation for Ask Starknet: usage guide, architecture explanation, capabilities listing, project ideas, and troubleshooting",
+    "description": "Help and documentation for Ask Starknet: usage guide, architecture explanation, capabilities listing like MCPs and tools, project ideas, and troubleshooting",
     "promptInfo": {
       "expertise": "Ask Starknet help, usage guide, documentation, architecture explanation, available MCPs and tools, project ideas, and troubleshooting",
       "tools": [

packages/mcp/mcps.local.json

@@ -432,5 +432,22 @@
       "expertise": "Cairo smart contract development, Starknet technical documentation, ecosystem knowledge, and recent Starknet news",
       "tools": ["assist_with_cairo", "starknet_general_knowledge"]
     }
+  },
+  "ask-starknet-help": {
+    "client": {
+      "command": "npx",
+      "args": ["-y", "@kasarlabs/ask-starknet-help-mcp@latest"],
+      "transport": "stdio"
+    },
+    "description": "Help and documentation for Ask Starknet: usage guide, architecture explanation, capabilities listing, project ideas, and troubleshooting",
+    "promptInfo": {
+      "expertise": "Ask Starknet help, usage guide, documentation, architecture explanation, available MCPs and tools, project ideas, and troubleshooting",
+      "tools": [
+        "ask_starknet_help",
+        "ask_starknet_explain_architecture",
+        "ask_starknet_list_capabilities",
+        "ask_starknet_suggest_projects"
+      ]
+    }
   }
 }

packages/mcp/src/graph/agents/selector.ts

@@ -73,7 +73,7 @@ Respond with the exact name of the chosen agent or "__end__".`;
       next: END,
       messages: [
         new AIMessage({
-          content: `I couldn't find an appropriate specialized agent to handle this request: "${userInput}"\n\nReasoning: ${response.reasoning}\n\nPlease try rephrasing your request or use one of the available capabilities. You can ask "help" to see what I can do.`,
+          content: `I couldn't find an appropriate specialized agent to handle this request: "${userInput}"\n\nPlease try rephrasing your request or use one of the available capabilities. You can ask "help" to see what I can do.`,
           name: 'selector-error',
         }),
       ],

packages/mcp/src/graph/mcps/utilities.ts

@@ -12,7 +12,14 @@ import { logger } from '../../utils/logger.js';
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = dirname(__filename);
 
+// Cache for loaded configuration
+let cachedConfig: Record<string, MCPServerInfo> | null = null;
+
 function loadMcpsConfig(): Record<string, MCPServerInfo> {
+  if (cachedConfig) {
+    return cachedConfig;
+  }
+
   try {
     // mcps.json is at the root of the package
     // From build/graph/mcps/utilities.js -> ../../../mcps.json
@@ -22,7 +29,9 @@ function loadMcpsConfig(): Record<string, MCPServerInfo> {
     }
     logger.info('Loading mcps.json from path:', configPath);
     const configContent = readFileSync(configPath, 'utf-8');
-    return JSON.parse(configContent);
+    const config: Record<string, MCPServerInfo> = JSON.parse(configContent);
+    cachedConfig = config;
+    return config;
   } catch (error) {
     console.error('Error loading mcps.json:', error);
     console.error('Tried path:', join(__dirname, '../../../mcps.json'));
@@ -75,9 +84,7 @@ export const getMCPClientConfig = (
 
     if (missingVars.length > 0) {
       throw new Error(
-        `Missing environment variables for MCP '${serverName}': ${missingVars.join(', ')}\n` +
-          `Available variables: ${Object.keys(env).join(', ')}\n` +
-          `Required variables: ${Object.keys(serverInfo.client.env).join(', ')}`
+        `Missing environment variables for MCP '${serverName}': ${missingVars.join(', ')}\n`
       );
     }
   }

packages/mcp/src/index.ts

@@ -9,6 +9,8 @@ import packageJson from '../package.json' with { type: 'json' };
 import { graph } from './graph/graph.js';
 import { logger } from './utils/logger.js';
 import { HumanMessage } from '@langchain/core/messages';
+import { getAllMcpInfo } from './graph/mcps/utilities.js';
+import type { MCPServerInfo } from './graph/mcps/interfaces.js';
 
 const performStarknetActionsSchema = z.object({
   userInput: z.string().describe('The actions that the user want to do'),
@@ -141,7 +143,20 @@ function validateRequiredEnvironmentVariables(): envInput {
     }
   }
 
-  Object.keys(process.env).forEach((key) => {
+  // Build whitelist from mcps.json - only collect env vars needed by MCPs
+  const mcpsConfig = getAllMcpInfo();
+  const allowedEnvVars = new Set<string>();
+
+  Object.values(mcpsConfig).forEach((mcpInfo: MCPServerInfo) => {
+    if (mcpInfo.client.env) {
+      Object.keys(mcpInfo.client.env).forEach((envVar) => {
+        allowedEnvVars.add(envVar);
+      });
+    }
+  });
+
+  // Only collect whitelisted environment variables
+  allowedEnvVars.forEach((key) => {
     if (process.env[key] && !env[key]) {
       env[key] = process.env[key];
     }