fix(tools): separate tools job (#222)

Author: HxSimo

packages/agent/src/agents/operators/supervisor/tools/createAgentTool.ts

@@ -1,7 +1,6 @@
 import { DynamicStructuredTool } from '@langchain/core/tools';
 import {
   AgentConfig,
-  McpServerConfig,
   logger,
   validateAgent,
   validateAgentQuotas,
@@ -29,7 +28,7 @@ export function createAgentTool(
   return new DynamicStructuredTool({
     name: 'create_agent',
     description:
-      'Create/add/make a new agent configuration for a specific user. Provide the agent profile (name, group, description) and optional configuration overrides for graph, memory, rag, plugins, mcp_servers, and prompts.',
+      'Create a new agent configuration with default settings. Only accepts agent profile (name, group, description, contexts). All other configuration (graph, memory, rag, mcp_servers) will use default values. To modify configuration after creation, use update_agent tool.',
     schema: CreateAgentSchema,
     func: async (rawInput) => {
       let input: CreateAgentInput;
@@ -105,10 +104,8 @@ export function createAgentTool(
           notes.push(nameNote);
         }
 
-        const { id: promptId, created: promptsCreated } = await ensurePromptsId(
-          userId,
-          input.prompts_id
-        );
+        const { id: promptId, created: promptsCreated } =
+          await ensurePromptsId(userId);
         if (promptsCreated) {
           notes.push('Default prompts initialized for the user.');
         }
@@ -159,52 +156,15 @@ export function createAgentTool(
 }
 
 function buildAgentConfigFromInput(input: CreateAgentInput): AgentConfig.Input {
-  // Build partial config from input - normalizeNumericValues will handle the rest
-  const partialConfig: Partial<AgentConfig.Input> = {};
-
-  // Only add properties that are actually provided
-  if (input.profile) {
-    partialConfig.profile = {
+  // Build partial config from input - only profile and prompts_id are allowed
+  const partialConfig: Partial<AgentConfig.Input> = {
+    profile: {
       name: input.profile.name.trim(),
       group: input.profile.group.trim(),
       description: input.profile.description.trim(),
       contexts: input.profile.contexts || [],
-    };
-  }
-
-  if (input.mcp_servers) {
-    // Convert array to Record<string, McpServerConfig>
-    const mcpServersRecord: Record<string, McpServerConfig> = {};
-    for (const server of input.mcp_servers) {
-      const { name, env, ...serverConfig } = server;
-
-      // Convert env array to Record<string, string>
-      let envRecord: Record<string, string> | undefined;
-      if (env && Array.isArray(env)) {
-        envRecord = {};
-        for (const envEntry of env) {
-          envRecord[envEntry.name] = envEntry.value;
-        }
-      }
-
-      mcpServersRecord[name] = {
-        ...serverConfig,
-        ...(envRecord && { env: envRecord }),
-      };
-    }
-
-    partialConfig.mcp_servers = parseMcpServers(mcpServersRecord, {});
-  }
-
-  if (input.graph)
-    partialConfig.graph = input.graph as AgentConfig.Input['graph'];
-
-  if (input.memory)
-    partialConfig.memory = input.memory as AgentConfig.Input['memory'];
-
-  if (input.rag) partialConfig.rag = input.rag;
-
-  if (input.prompts_id) partialConfig.prompts_id = input.prompts_id;
+    },
+  };
 
   // Apply normalization using the centralized function - it handles all defaults and validation
   const { normalizedConfig, appliedDefaults } =
@@ -220,16 +180,6 @@ function buildAgentConfigFromInput(input: CreateAgentInput): AgentConfig.Input {
   return normalizedConfig;
 }
 
-function parseMcpServers(
-  value: Record<string, McpServerConfig> | undefined,
-  fallback: Record<string, McpServerConfig>
-): Record<string, McpServerConfig> {
-  if (value && typeof value === 'object' && !Array.isArray(value)) {
-    return value;
-  }
-  return { ...fallback };
-}
-
 async function resolveUniqueAgentName(
   baseName: string,
   group: string,

packages/agent/src/agents/operators/supervisor/tools/schemas/createAgent.schema.ts

@@ -1,27 +1,12 @@
 import { z } from 'zod';
-import {
-  AgentProfileSchema,
-  GraphConfigSchema,
-  MemoryConfigSchema,
-  RAGConfigSchema,
-  McpServersArraySchema,
-} from './common.schemas.js';
+import { AgentProfileSchema } from './common.schemas.js';
 
-// Main schema for creating an agent (profile required, other fields optional)
+// Main schema for creating an agent (only profile and prompts_id allowed)
 export const CreateAgentSchema = z
   .object({
-    profile: AgentProfileSchema.describe('Agent profile configuration'),
-    mcp_servers: McpServersArraySchema.optional().describe(
-      'MCP servers configuration'
+    profile: AgentProfileSchema.describe(
+      'Agent profile configuration (required)'
     ),
-    memory: MemoryConfigSchema.optional().describe('Memory configuration'),
-    rag: RAGConfigSchema.optional().describe('RAG configuration'),
-    prompts_id: z
-      .string()
-      .uuid()
-      .optional()
-      .describe('Existing prompts configuration identifier'),
-    graph: GraphConfigSchema.optional().describe('Graph configuration'),
   })
   .strict();
 

packages/agent/src/agents/operators/supervisor/tools/schemas/updateAgent.schema.ts

@@ -4,23 +4,17 @@ import {
   GraphConfigSchema,
   MemoryConfigSchema,
   RAGConfigSchema,
-  McpServerConfigSchema,
   SelectAgentSchema,
-  McpServersArraySchema,
 } from './common.schemas.js';
-import { getGuardValue } from '@snakagent/core';
 
-const maxMcpServer = getGuardValue('agents.mcp_servers.max_servers');
 // Schema for update agent - allows partial updates with nullable fields
+// Note: mcp_servers is NOT included here - use add_mcp_server, update_mcp_server, or remove_mcp_server tools instead
 export const UpdateAgentSchema = SelectAgentSchema.extend({
   updates: z
     .object({
       profile: AgentProfileSchema.partial()
         .optional()
         .describe('Agent profile configuration (partial)'),
-      mcp_servers: McpServersArraySchema.optional().describe(
-        'MCP servers configuration'
-      ),
       memory: MemoryConfigSchema.optional().describe('Memory configuration'),
       rag: RAGConfigSchema.optional().describe('RAG configuration'),
       prompts_id: z