Support empty rhsm_url setting on proxies

This drops the compatibility fallbacks that were in place for pre-3.1
installations. Since then the value has been present.

Now it becomes possible to not set a value which means the RHSM URL is
on the Foreman instance itself. This is useful for Pulp-only
installations without any RHSM reverse proxy setup.

Author: ekohl

Diff for: app/models/katello/concerns/smart_proxy_extensions.rb

@@ -611,14 +611,13 @@ def up_to_date?(environment = nil, content_view = nil)
       end
 
       def rhsm_url
-        # Since Foreman 3.1 this setting is set
-        if (rhsm_url = setting(SmartProxy::PULP3_FEATURE, 'rhsm_url'))
-          URI(rhsm_url)
-          # Compatibility fall back
-        elsif pulp_primary?
-          URI("https://#{URI.parse(url).host}/rhsm")
-        elsif pulp_mirror?
-          URI("https://#{URI.parse(url).host}:8443/rhsm")
+        if (rhsm_url_setting = setting(SmartProxy::PULP3_FEATURE, 'rhsm_url').presence)
+          URI(rhsm_url_setting)
+        else
+          # TODO: get this from routes
+          uri = URI.parse(Setting[:foreman_url])
+          uri.path = '/rhsm'
+          uri
         end
       end
 

Diff for: test/models/concerns/smart_proxy_extensions_test.rb

@@ -399,13 +399,18 @@ def test_save_with_organization_location
       assert_equal @proxy_mirror.lifecycle_environments.all.count, 0
     end
 
-    def test_rhsm_url_pulp_primary
-      assert_includes @proxy.rhsm_url.to_s, "/rhsm"
-      assert_not_includes @proxy.rhsm_url.to_s, ":8443"
+    def test_rhsm_url_without_rhsm_url_setting
+      Setting[:foreman_url] = 'https://foreman.example.com/'
+      proxy = FactoryBot.build(:smart_proxy, :with_pulp3)
+      assert_equal proxy.rhsm_url.to_s, "https://foreman.example.com/rhsm"
     end
 
-    def test_rhsm_url_pulp_mirror
-      assert_includes @proxy_mirror.rhsm_url.to_s, ":8443/rhsm"
+    def test_rhsm_url_with_rhsm_url_setting
+      proxy = FactoryBot.create(:smart_proxy, :with_pulp3)
+      feature = proxy.smart_proxy_features.find_by(feature: Feature.find_by(name: ::SmartProxy::PULP3_FEATURE))
+      feature.settings[:rhsm_url] = 'https://rhsm.example.com/rhsm'
+      feature.save!
+      assert_equal proxy.rhsm_url.to_s, 'https://rhsm.example.com/rhsm'
     end
 
     def test_sync_container_gateway