Fixes #38191: Skip reassignment for multiCV in remove

Author: pavanshekar

webpack/scenes/ContentViews/Details/Versions/Delete/RemoveSteps/CVEnvironmentSelectionForm.js

@@ -1,18 +1,40 @@
 import React, { useContext, useState } from 'react';
+import { useSelector, useDispatch } from 'react-redux';
 import useDeepCompareEffect from 'use-deep-compare-effect';
 import { Alert, Checkbox, EmptyState, EmptyStateVariant, Title, EmptyStateBody, AlertActionCloseButton } from '@patternfly/react-core';
 import { TableVariant, TableComposable, Thead, Tbody, Tr, Th, Td } from '@patternfly/react-table';
 import { translate as __ } from 'foremanReact/common/I18n';
 import DeleteContext from '../DeleteContext';
+import { selectCVHosts, selectCVActivationKeys } from '../../../ContentViewDetailSelectors';
+import { getHosts, getActivationKeys } from '../../../ContentViewDetailActions';
 
 const CVEnvironmentSelectionForm = () => {
   const [alertDismissed, setAlertDismissed] = useState(false);
   const {
+    cvId,
     versionNameToRemove, versionEnvironments, selectedEnvSet,
     setAffectedActivationKeys, setAffectedHosts, deleteFlow,
     removeDeletionFlow, setRemoveDeletionFlow,
   } = useContext(DeleteContext);
 
+  const dispatch = useDispatch();
+  const hostsResponse = useSelector(selectCVHosts);
+  const activationKeysResponse = useSelector(selectCVActivationKeys);
+
+  useDeepCompareEffect(() => {
+    const selectedEnv = versionEnvironments.filter(env => selectedEnvSet.has(env.id));
+
+    let cvQuery = `content_view_id=${cvId}`;
+    const selectedEnvStringsForHosts = selectedEnv.map(env => `lifecycle_environment_id=${env.id}`).join(' OR ');
+    if (selectedEnvStringsForHosts.length) cvQuery += ` AND (${selectedEnvStringsForHosts})`;
+    dispatch(getHosts({ search: cvQuery }));
+
+    let akQuery = `content_view_id=${cvId}`;
+    const selectedEnvStringsForAK = selectedEnv.map(env => `lifecycle_environment_id=${env.id}`).join(' OR ');
+    if (selectedEnvStringsForAK.length) akQuery += ` AND (${selectedEnvStringsForAK})`;
+    dispatch(getActivationKeys({ search: akQuery }));
+  }, [dispatch, cvId, versionEnvironments, selectedEnvSet]);
+
   const areAllSelected = () => versionEnvironments.every(env => selectedEnvSet.has(env.id));
 
   const onSelect = (_event, isSelected, rowId) => {
@@ -26,10 +48,24 @@ const CVEnvironmentSelectionForm = () => {
   // Based on env selected for removal, decide if we need to reassign hosts and activation keys.
   useDeepCompareEffect(() => {
     const selectedEnv = versionEnvironments.filter(env => selectedEnvSet.has(env.id));
-    setAffectedActivationKeys(!!(selectedEnv.filter(env => env.activation_key_count > 0).length));
-    setAffectedHosts(!!(selectedEnv.filter(env => env.host_count > 0).length));
+
+    if (activationKeysResponse?.results?.length > 0 &&
+      activationKeysResponse.results.every(key => key.multi_content_view_environment)) {
+      setAffectedActivationKeys(false);
+    } else {
+      setAffectedActivationKeys(!!(selectedEnv.filter(env =>
+        env.activation_key_count > 0).length));
+    }
+    if (hostsResponse?.results?.length > 0 &&
+      hostsResponse.results.every(host =>
+        host.content_facet_attributes?.multi_content_view_environment)) {
+      setAffectedHosts(false);
+    } else {
+      setAffectedHosts(!!(selectedEnv.filter(env => env.host_count > 0).length));
+    }
   }, [setAffectedActivationKeys, setAffectedHosts,
-    versionEnvironments, selectedEnvSet, selectedEnvSet.size]);
+    versionEnvironments, selectedEnvSet, selectedEnvSet.size,
+    hostsResponse, activationKeysResponse]);
 
   const onSelectAll = (event, isSelected) => {
     if (!isSelected) {

webpack/scenes/ContentViews/Details/Versions/Delete/__tests__/cvVersionRemove.test.js

@@ -76,6 +76,16 @@ test('Can open Remove wizard and remove version from simple environment', async
     .query(true)
     .reply(200, environmentPathsData);
 
+  const hostScope = nockInstance
+    .get(hostURL)
+    .query(true)
+    .reply(200, affectedHostData);
+
+  const activationKeysScope = nockInstance
+    .get(activationKeyURL)
+    .query(true)
+    .reply(200, affectedActivationKeysData);
+
   const cvVersionRemoveParams = { id: 2, environment_ids: [4] };
 
   const versionRemovalScope = nockInstance
@@ -115,13 +125,19 @@ test('Can open Remove wizard and remove version from simple environment', async
   assertNockRequest(scope);
   assertNockRequest(autocompleteScope);
   assertNockRequest(envPathRemovalScope);
+  assertNockRequest(hostScope);
+  assertNockRequest(activationKeysScope);
   assertNockRequest(versionRemovalScope, done);
 });
 
 test('Can open Remove wizard and remove version from environment with hosts', async (done) => {
   const autocompleteScope = mockAutocomplete(nockInstance, autocompleteUrl);
   const hostAutocompleteUrl = '/hosts/auto_complete_search';
   const hostAutocompleteScope = mockForemanAutocomplete(nockInstance, hostAutocompleteUrl);
+  const hostAutocompleteMock = nockInstance
+    .get(foremanApi.getApiUrl(hostAutocompleteUrl))
+    .query({ organization_id: '1', search: '' })
+    .reply(200, { results: [] });
 
   const scope = nockInstance
     .get(cvVersions)
@@ -133,11 +149,21 @@ test('Can open Remove wizard and remove version from environment with hosts', as
     .query(true)
     .reply(200, environmentPathsData);
 
+  const initialHostScope = nockInstance
+    .get(hostURL)
+    .query({ organization_id: '1', search: 'content_view_id=2' })
+    .reply(200, { results: [] });
+
   const hostScope = nockInstance
     .get(hostURL)
-    .query(true)
+    .query({ organization_id: '1', search: 'content_view_id=2 AND (lifecycle_environment_id=6)' })
     .reply(200, affectedHostData);
 
+  const activationKeysScope = nockInstance
+    .get(activationKeyURL)
+    .query(true)
+    .reply(200, { results: [] });
+
   const cVDropDownOptionsScope = nockInstance
     .get(cVDropDownOptionsPath)
     .reply(200, cVDropDownOptionsData);
@@ -199,7 +225,10 @@ test('Can open Remove wizard and remove version from environment with hosts', as
   assertNockRequest(scope);
   assertNockRequest(autocompleteScope);
   assertNockRequest(hostAutocompleteScope);
+  assertNockRequest(hostAutocompleteMock);
+  assertNockRequest(initialHostScope);
   assertNockRequest(hostScope);
+  assertNockRequest(activationKeysScope);
   assertNockRequest(cVDropDownOptionsScope);
   assertNockRequest(envPathRemovalScope);
   assertNockRequest(versionRemovalScope, done);
@@ -209,6 +238,10 @@ test('Can open Remove wizard and remove version from environment with activation
   const autocompleteScope = mockAutocomplete(nockInstance, autocompleteUrl);
   const akAutocompleteUrl = '/activation_keys/auto_complete_search';
   const akAutocompleteScope = mockAutocomplete(nockInstance, akAutocompleteUrl);
+  const activationKeysAutocompleteMock = nockInstance
+    .get(api.getApiUrl(akAutocompleteUrl))
+    .query({ organization_id: '1', search: '' })
+    .reply(200, { results: [] });
 
   const scope = nockInstance
     .get(cvVersions)
@@ -220,11 +253,21 @@ test('Can open Remove wizard and remove version from environment with activation
     .query(true)
     .reply(200, environmentPathsData);
 
+  const initialActivationKeyScope = nockInstance
+    .get(activationKeyURL)
+    .query({ organization_id: '1', search: 'content_view_id=2' })
+    .reply(200, { results: [] });
+
   const activationKeysScope = nockInstance
     .get(activationKeyURL)
-    .query(true)
+    .query({ organization_id: '1', search: 'content_view_id = 2 AND ( environment=test2 )' })
     .reply(200, affectedActivationKeysData);
 
+  const hostScope = nockInstance
+    .get(hostURL)
+    .query(true)
+    .reply(200, { results: [] });
+
   const cVDropDownOptionsScope = nockInstance
     .get(cVDropDownOptionsPath)
     .reply(200, cVDropDownOptionsData);
@@ -287,7 +330,10 @@ test('Can open Remove wizard and remove version from environment with activation
   assertNockRequest(scope);
   assertNockRequest(autocompleteScope);
   assertNockRequest(akAutocompleteScope);
+  assertNockRequest(activationKeysAutocompleteMock);
+  assertNockRequest(initialActivationKeyScope);
   assertNockRequest(activationKeysScope);
+  assertNockRequest(hostScope);
   assertNockRequest(cVDropDownOptionsScope);
   assertNockRequest(envPathRemovalScope);
   assertNockRequest(versionRemovalScope, done);